Skip to content

fix(agw): Fixed file not found error in publishing integ test status#13568

Merged
ardzoht merged 4 commits intomagma:masterfrom
VinashakAnkitAman:ankit_fixed_file_not_found_error_in_publishing_integ_test_status
Aug 11, 2022
Merged

fix(agw): Fixed file not found error in publishing integ test status#13568
ardzoht merged 4 commits intomagma:masterfrom
VinashakAnkitAman:ankit_fixed_file_not_found_error_in_publishing_integ_test_status

Conversation

@VinashakAnkitAman
Copy link
Copy Markdown
Member

Title

fix(agw): Fixed file not found error in publishing integ test status

Summary

Whenever LTE integ test run fails in CI before triggering the actual integ test execution (during system bring-up or configuration phase), the status file goes missing and it leads to file not found exception and CI status is not updated for the integ test. This PR fixes the issue by getting the status of the integ test only if status file exists.

The error log:

Traceback (most recent call last):
  File "ci-scripts/firebase_publish_report.py", line 114, in <module>
    args.func(args)
  File "ci-scripts/firebase_publish_report.py", line 68, in lte_integ_test
    with open('test_status.txt', 'r') as file:
FileNotFoundError: [Errno 2] No such file or directory: 'test_status.txt'
Error: Process completed with exit code 1.

Test plan

Verified with sanity and in CI
Successful CI execution log:
https://github.com/VinashakAnkitAman/magma/actions/runs/2832919308
Reference CI run: https://github.com/magma/magma/runs/7752890817?check_suite_focus=true

Signed-off-by: VinashakAnkitAman [email protected]

@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner August 10, 2022 13:23
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 10, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 10, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 10, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 90c17da.

♻️ This comment has been updated with latest results.

Comment thread ci-scripts/firebase_publish_report.py
Signed-off-by: VinashakAnkitAman <[email protected]>
@VinashakAnkitAman VinashakAnkitAman requested a review from a team August 11, 2022 12:15
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 11, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 11, 2022
Signed-off-by: VinashakAnkitAman <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit f1219fa.

Signed-off-by: VinashakAnkitAman <[email protected]>
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 11, 2022
@github-actions github-actions bot removed the component: agw Access gateway-related issue label Aug 11, 2022
@VinashakAnkitAman VinashakAnkitAman removed the request for review from a team August 11, 2022 13:43
@ardzoht ardzoht merged commit fdca34c into magma:master Aug 11, 2022
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
…13568)

* fix(agw): Fixed file not found error in publishing integ test status

Signed-off-by: VinashakAnkitAman <[email protected]>

* Temporary change and will be removed

Signed-off-by: VinashakAnkitAman <[email protected]>

* Temporary change and will be removed

Signed-off-by: VinashakAnkitAman <[email protected]>

* Removed Temporary changes

Signed-off-by: VinashakAnkitAman <[email protected]>

Signed-off-by: VinashakAnkitAman <[email protected]>
(cherry picked from commit fdca34c)
@github-actions
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

maxhbr pushed a commit that referenced this pull request Aug 17, 2022
…13568) (#13634)

* fix(agw): Fixed file not found error in publishing integ test status

Signed-off-by: VinashakAnkitAman <[email protected]>

* Temporary change and will be removed

Signed-off-by: VinashakAnkitAman <[email protected]>

* Temporary change and will be removed

Signed-off-by: VinashakAnkitAman <[email protected]>

* Removed Temporary changes

Signed-off-by: VinashakAnkitAman <[email protected]>

Signed-off-by: VinashakAnkitAman <[email protected]>
(cherry picked from commit fdca34c)

Co-authored-by: Ankit Kumar Aman <[email protected]>
@nstng
Copy link
Copy Markdown
Contributor

nstng commented Aug 24, 2022

already in 1.8 - setting respective label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.8 backported-v1.8 candidate-for-backporting component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants