Skip to content

fix(agw): Enhanced debugging in CI for agw#13423

Merged
pruthvihebbani merged 5 commits intomagma:masterfrom
VinashakAnkitAman:ankit_enhanced_debugging_options
Aug 11, 2022
Merged

fix(agw): Enhanced debugging in CI for agw#13423
pruthvihebbani merged 5 commits intomagma:masterfrom
VinashakAnkitAman:ankit_enhanced_debugging_options

Conversation

@VinashakAnkitAman
Copy link
Copy Markdown
Member

@VinashakAnkitAman VinashakAnkitAman commented Jul 26, 2022

Title

fix(agw): Enhanced debugging in CI for agw

Summary

During the CI run, many test cases are there which restart MME causing multiple MME log files generation in the Dev VM. However, after execution of lte integ test, we are fetching only the last MME log. This PR adds code to fetch all MME logs from Dev VM. Moreover the integ test execution is not updating the status properly after execution because of which artifact logs are not published when the CI runs are failing. This PR fixes the integ test status issue. The PR changes does the following:

  • Fetches all the MME logs from the Dev VM after integ test execution
  • Fetches the final integ test status and update the command execution output with failure for failing executions
  • Shifts the ignoring of failing test case from overall integ test case execution to the command execution individually
  • Removes the unnecessary sleep after test case execution

Test plan

Verified with sanity and in CI
Successful CI execution log:
https://github.com/VinashakAnkitAman/magma/actions/runs/2740579763
https://github.com/VinashakAnkitAman/magma/actions/runs/2803524233

Signed-off-by: VinashakAnkitAman [email protected]

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 26, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Jul 26, 2022
Signed-off-by: VinashakAnkitAman <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 26, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit d8a7f40.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 26, 2022

dp-workflow

15 tests   15 ✔️  3m 51s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d8a7f40.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 26, 2022

agw-workflow

615 tests   611 ✔️  3m 49s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit d8a7f40.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 5, 2022
@VinashakAnkitAman VinashakAnkitAman marked this pull request as ready for review August 5, 2022 12:42
@VinashakAnkitAman VinashakAnkitAman requested a review from a team August 5, 2022 12:42
@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner August 5, 2022 12:42
Comment thread lte/gateway/python/integ_tests/Makefile
Comment thread lte/gateway/fabfile.py
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MagmaCIBot pushed a commit that referenced this pull request Aug 24, 2022
* fix(agw): Enhanced debugging in CI for agw

Signed-off-by: VinashakAnkitAman <[email protected]>

* Fixed CI status update for failing CI runs

Signed-off-by: VinashakAnkitAman <[email protected]>

Signed-off-by: VinashakAnkitAman <[email protected]>
(cherry picked from commit dabdd02)
@MagmaCIBot
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tmdzk pushed a commit that referenced this pull request Aug 24, 2022
* fix(agw): Enhanced debugging in CI for agw

Signed-off-by: VinashakAnkitAman <[email protected]>

* Fixed CI status update for failing CI runs

Signed-off-by: VinashakAnkitAman <[email protected]>

Signed-off-by: VinashakAnkitAman <[email protected]>
(cherry picked from commit dabdd02)

Co-authored-by: Ankit Kumar Aman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported-v1.8 component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants