feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 by prabinakpattnaik · Pull Request #13020 · magma/magma

prabinakpattnaik · 2022-06-18T14:04:31Z

Signed-off-by: prabina pattnaik [email protected]

Summary

Router Advertisement not getting generated for 5G UE IPv6 [Issue ID #12871 ]

Below are functionality supported in this PR:
For 4g and 5g controller ID is different value used.
So, ipv6 solicitation flows are inserted into table 3 with Action value different based on cotroller ID
For 5g, output of table=3:

vagrant@magma-dev-focal:~/magma/lte/gateway$ sudo ovs-ofctl -O OpenFlow13 dump-flows gtp_br0 table=3
 cookie=0x0, duration=52.337s, table=3, n_packets=0, n_bytes=0, priority=10,icmp6,reg1=0x1,ipv6_src=fe80::/10,icmp_type=133 actions=controller(reason=action_set,max_len=0,id=5),CONTROLLER:65535
 cookie=0x0, duration=52.320s, table=3, n_packets=0, n_bytes=0, priority=10,icmp6,reg1=0x1,ipv6_src=fe80::/10,icmp_type=135 actions=controller(reason=action_set,max_len=0,id=5),CONTROLLER:65535
 cookie=0x0, duration=52.318s, table=3, n_packets=0, n_bytes=0, priority=10,icmp6,reg1=0x10,ipv6_dst=ff02::1:ff00:0/104,icmp_type=135 actions=controller(reason=action_set,max_len=0,id=5),CONTROLLER:65535

Need to add GNB IP address in "/etc/network/interfaces.d/gtp" at port gtp0 for sending the Router adverstisemnt message to target device:

        Port gtp0
            Interface gtp0
                type: gtpu
                options: {key=flow, remote_ip="192.168.60.20"}

Test Plan

Using UERANSIM simulator, we have verified this functionality.

Additional Information

Logs:
IP Address Allocated for IPv6:

Jun 17 20:39:21 magma-dev-focal mobilityd[183930]: INFO:root:Allocated IP fdee:5:6c:2db6:dcb0:b4af:481d:1f1 for sid IMSI901700000000001 for apn internet
Jun 17 20:39:21 magma-dev-focal policydb[184001]: INFO:root:Creating a session for subscriber ID: IMSI901700000000001

IPV6SolicitationController logs when received Router Solicitation from UE:

Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:magma.pipelined.openflow.flows:flowmod: version=None,msg_type=None,msg_len=None,xid=None,OFPFlowStatsRequest(cookie=0,cookie_mask=0,flags=0,match=OFPMatch(oxm_fields={}),out_group=4294967295,out_port=4294967295,table_id=14,type=1) (table 14)
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:Received PKT -> on port 32768 tun_id: 2147483647 tun_id_dst: 1
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:ethernet(dst='ff:ff:ff:ff:ff:ff',ethertype=34525,src='02:00:00:00:00:01')
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:ipv6(dst='ff02::2',ext_hdrs=[],flow_label=0,hop_limit=255,nxt=58,payload_length=8,src='fe80::dcb0:b4af:481d:1f1',traffic_class=0,version=6)
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:icmpv6(code=0,csum=41416,data=nd_router_solicit(option=None,res=0),type_=133)
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:Received router solicitation MSG
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:RA pkt response ->
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:ethernet(dst='33:33:00:00:00:01',ethertype=34525,src='08:00:27:eb:e7:39')
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:ipv6(dst='fe80::dcb0:b4af:481d:1f1',ext_hdrs=[],flow_label=0,hop_limit=255,nxt=58,payload_length=0,src='fe80::a00:27ff:fe90:db2c',traffic_class=0,version=6)
Jun 17 20:42:38 magma-dev-focal pipelined[184051]: DEBUG:IPV6SolicitationController:icmpv6(code=0,csum=0,data=nd_router_advert(ch_l=255,options=[nd_option_sla(data=None,hw_src='08:00:27:eb:e7:39',length=0), nd_option_pi(length=0,pl=64,pre_l=4294967295,prefix='fdee:5:6c:2db6::',res1=6,res2=0,val_l=4294967295)],rea_t=0,res=0,ret_t=0,rou_l=65535),type_=134)

github-actions · 2022-06-18T14:04:45Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-06-18T14:07:01Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

github-actions · 2022-06-18T14:12:39Z

dp-workflow

13 tests 13 ✔️ 2m 46s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 9be14cb.

♻️ This comment has been updated with latest results.

github-actions · 2022-06-18T14:13:23Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 9be14cb.

♻️ This comment has been updated with latest results.

github-actions · 2022-06-18T14:32:35Z

cloud-workflow

1 009 tests 1 009 ✔️ 2m 12s ⏱️
  356 suites       0 💤
      7 files       0 ❌

Results for commit 9be14cb.

♻️ This comment has been updated with latest results.

github-actions · 2022-06-18T15:09:11Z

agw-workflow

615 tests 611 ✔️ 3m 46s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 9be14cb.

♻️ This comment has been updated with latest results.

nstng

Will continue when first set of comments is addressed.

nstng · 2022-06-23T07:10:06Z

            ipv6_src=ipv6_src,
            ll_addr=config_dict['virtual_mac'],
            prefix_len=self.DEFAULT_PREFIX_LEN,
+            ng_service_enabled=ng_service,


ng_service_enabled True is not tested in test_ipv6_solicitation. Does a test make sense here? What is expected if it is True, but classifier_controller_id is not set?

The classifier_controller_id value set to 5 in pipelined.yml.
This value used for 5G RYU controller set value for packetIN events.

pshelar · 2022-07-11T18:20:35Z

+                self.uplink_port_name,
+            )
+        else:
+            self._uplink_port = OFPP_LOCAL


This PR is trying to implement two different functionality.

Non-NAT

Add support for IPv6.

Please separate it in two separate PRs with its own unit tests.

@pshelar , we have fixed it as per your suggestion.

Created PR Support for Non-NAT mode in 5G-SA feat(pipelined): Support for Non-NAT mode in 5G-SA #13288 and merged into master.

Rebased with master and added UT for ipv6 solicitation
python/magma/pipelined/tests/test_ipv6_solicitation_5g.py

We have verified with UERANSIM for below functionality and along with end-to-end traffic flows:
Router Solicitation
Router Advertisement
IPv6 traffic with TCP.

Attached logs and pcap file for same.

tc2.txt
IPv6_Traffic_flows.zip

github-actions · 2022-08-11T18:41:04Z

    far_rule = FARRuleEntry(
        far_entry.far_action_to_apply[0],
-        o_teid, fwd_gnb_ip_addr,
+        fwd_gnb_ip_addr,


🚫 [mypy] _{reported by reviewdog 🐶}
Argument 2 to "FARRuleEntry" has incompatible type "Optional[Any]"; expected "str" [arg-type]

maxhbr · 2022-08-11T21:48:42Z

please rebase and fix Bazel Build & Test

prabinakpattnaik · 2022-08-13T13:59:02Z

@pshelar , @maxhbr , now all required checks are passed and fixed the rebase check as well. Could you please push the changes into master.

Signed-off-by: prabina pattnaik <[email protected]>

nstng

Bazel changes lgtm

GANESH-WAVELABS

Sessiond Changes LGTM

* feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> Signed-off-by: prabina pattnaik <[email protected]> (cherry picked from commit 02aa0bb)

github-actions · 2022-08-17T08:22:13Z

💚 All backports created successfully

Status	Branch	Result
✅	v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

… (#13632) * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> * feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 Signed-off-by: prabina pattnaik <[email protected]> Signed-off-by: prabina pattnaik <[email protected]> (cherry picked from commit 02aa0bb) Co-authored-by: prabinakpattnaik <[email protected]>

prabinakpattnaik requested review from a team June 18, 2022 14:04

prabinakpattnaik requested a review from a team as a code owner June 18, 2022 14:04

prabinakpattnaik requested review from GANESH-WAVELABS, ardzoht and nstng June 18, 2022 14:04

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jun 18, 2022

github-actions bot added the component: agw Access gateway-related issue label Jun 18, 2022

pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jun 18, 2022

github-actions bot added the component: orc8r Orchestrator-related issue label Jun 18, 2022

nstng reviewed Jun 23, 2022

View reviewed changes

prabinakpattnaik force-pushed the IPv6_Router_Adver_5G branch 2 times, most recently from 4bbb4df to dc9aa5f Compare June 28, 2022 13:40

prabinakpattnaik requested review from koolzz and pshelar July 7, 2022 18:22

pshelar requested changes Jul 11, 2022

View reviewed changes

prabinakpattnaik force-pushed the IPv6_Router_Adver_5G branch from dc9aa5f to b83e8aa Compare July 18, 2022 07:58

panyogesh requested a review from pshelar July 25, 2022 08:16

pshelar approved these changes Jul 27, 2022

View reviewed changes

prabinakpattnaik force-pushed the IPv6_Router_Adver_5G branch from 3d680bb to 1f6795d Compare August 11, 2022 18:39

github-actions bot reviewed Aug 11, 2022

View reviewed changes

prabinakpattnaik requested a review from a team August 11, 2022 19:24

maxhbr mentioned this pull request Aug 15, 2022

test_ipv6_solicitation.py contains dead code which should be cleaned up #13616

Closed

prabinakpattnaik added 13 commits August 16, 2022 11:13

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

fcb29fc

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

ea68383

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

33b65d7

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

4f8cf6d

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

90c76e9

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

3663cb6

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

553459b

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

bcbbf92

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

6ca275c

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

d765296

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

dd3a32e

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

adc76ca

Signed-off-by: prabina pattnaik <[email protected]>

feat(pipelined): Router Advertisement issue fix for 5G UE IPv6

9be14cb

Signed-off-by: prabina pattnaik <[email protected]>

prabinakpattnaik force-pushed the IPv6_Router_Adver_5G branch from 8657480 to 9be14cb Compare August 16, 2022 11:16

nstng self-requested a review August 16, 2022 12:45

nstng approved these changes Aug 16, 2022

View reviewed changes

GANESH-WAVELABS approved these changes Aug 16, 2022

View reviewed changes

pshelar merged commit 02aa0bb into magma:master Aug 16, 2022

maxhbr added the apply-v1.8 label Aug 17, 2022

github-actions bot mentioned this pull request Aug 17, 2022

[v1.8] feat(pipelined): Router Advertisement issue fix for 5G UE IPv6 (#13020) #13632

Merged

maxhbr added backported-v1.8 and removed candidate-for-backporting labels Aug 17, 2022

Koki1323 approved these changes Aug 17, 2022

View reviewed changes

panyogesh mentioned this pull request Aug 24, 2022

[pipelined]: Router Advertisement not getting generated for 5G UE IPv6 calls #12871

Closed

thinhnt1983 mentioned this pull request Sep 19, 2022

[LTE Integ Flakiness] Router Advertisement issue #13951

Closed

Conversation

prabinakpattnaik commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Additional Information

Uh oh!

github-actions bot commented Jun 18, 2022

Howto

More info

Uh oh!

github-actions bot commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Howto

Uh oh!

github-actions bot commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dp-workflow

Uh oh!

github-actions bot commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feg-workflow

Uh oh!

github-actions bot commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cloud-workflow

Uh oh!

github-actions bot commented Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

agw-workflow

Uh oh!

nstng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nstng Jun 23, 2022

Choose a reason for hiding this comment

Uh oh!

prabinakpattnaik Jun 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pshelar Jul 11, 2022

Choose a reason for hiding this comment

Uh oh!

prabinakpattnaik Jul 18, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

maxhbr commented Aug 11, 2022

Uh oh!

prabinakpattnaik commented Aug 13, 2022

Uh oh!

nstng left a comment

Choose a reason for hiding this comment

Uh oh!

GANESH-WAVELABS left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 17, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

prabinakpattnaik commented Jun 18, 2022 •

edited

Loading

github-actions bot commented Jun 18, 2022 •

edited

Loading

github-actions bot commented Jun 18, 2022 •

edited

Loading

github-actions bot commented Jun 18, 2022 •

edited

Loading

github-actions bot commented Jun 18, 2022 •

edited

Loading

github-actions bot commented Jun 18, 2022 •

edited

Loading

nstng left a comment •

edited

Loading