Skip to content

Add hash to core extensions#399

Merged
Ocramius merged 1 commit into
maglnet:4.6.xfrom
cedric-anne:fix/hash-core-extension
Apr 21, 2023
Merged

Add hash to core extensions#399
Ocramius merged 1 commit into
maglnet:4.6.xfrom
cedric-anne:fix/hash-core-extension

Conversation

@cedric-anne

Copy link
Copy Markdown
Contributor

As of PHP 7.4.0, the Hash extension is a core PHP extension, so it is always enabled.

see https://www.php.net/manual/en/hash.installation.php

@cedric-anne
cedric-anne changed the base branch from 4.6.x to 4.5.x April 21, 2023 09:35
@cedric-anne

Copy link
Copy Markdown
Contributor Author

I set 4.5.x as target as I think it can be considered as a bug.

@Ocramius
Ocramius changed the base branch from 4.5.x to 4.6.x April 21, 2023 21:06
@Ocramius Ocramius added this to the 4.6.0 milestone Apr 21, 2023
@Ocramius Ocramius self-assigned this Apr 21, 2023

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the target branch to 4.6.x:

  • the patch wasn't based on the bugfix branch, so it was a bit noisy
  • this is pretty much an improvement: upgrading to 4.6.0 should be a no-brainer for consumers anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants