Skip to content

Conversation

@mobid
Copy link

@mobid mobid commented Dec 14, 2023

I'm using self hosted gitea on regular basis, so here is the result.

From day to day use I found two bugs:

  1. forge-add-repository doesn't pull topics at first time (same behaviour has github)
  2. forge-pull-notifications most times throw error:

    error in process filter: json-read: Unrecognized keyword: "f51"
    ^ Probably broken read of chunked http response?

Tested:

  • Pull request
    • Create
    • Assign
    • Close/Open
    • Drafts (no drafts, only WIP prefix)
    • Milestones
    • Labels
    • Assignees
    • Review-Requests
  • Issues
    • Create
    • Assign
    • Close/Open
    • Milestones
    • Labels
    • Marks (there is no such thing in gitea?)
    • Assignees
  • Commenting (comment, edit, delete)
  • Merge
  • Notifications - need another check
  • Templates - need another check

Any suggestions/tips are welcome.

Tested:
- [X] Pull request
  - [X] Create
  - [X] Assign
  - [X] Close/Open
  - [ ] Drafts (no drafts, only WIP prefix)
  - [X] Milestones
  - [X] Labels
  - [X] Assignees
  - [X] Review-Requests
- [-] Issues
  - [X] Create
  - [X] Assign
  - [X] Close/Open
  - [X] Milestones
  - [X] Labels
  - [ ] Marks (there is no such thing in gitea?)
  - [X] Assignees
- [X] Commenting (comment, edit, delete)
- [X] Merge
@mobid mobid marked this pull request as draft December 14, 2023 23:30
@mobid mobid marked this pull request as ready for review December 14, 2023 23:30
@tarsius
Copy link
Member

tarsius commented Dec 14, 2023

This has been suggested a few times before.

There also was a pull-request that added notification support (#431). In response to that I started working on that myself. The early results can be seen in the [dump] support gitea commit on the idea branch.

But I abandoned that work. I now think that it was a mistake to support more than one forge initially; it slows down development considerably. The Gitlab implementation, which most other implementations would be based on, is lacking. One problem is callback hell. Until I have improved the Gitlab implementation, I don't want to add other implementations that are based on that.

So I'm afraid you will have to maintain that as a separate package and you will also end up having to deal with breaking changes. I'm sorry I cannot do better than that at this time. Forge is a big time sink and I am prioritizing paying of technical dept over supporting more forges (which would mean increasing the dept).

@mobid mobid marked this pull request as draft December 14, 2023 23:40
@mobid
Copy link
Author

mobid commented Dec 17, 2023

Ok. I will pack it separately. Thank you.

@tarsius tarsius added the wont add This feature will not be worked on label Dec 21, 2023
@tarsius tarsius closed this Dec 21, 2023
@tarsius tarsius mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wont add This feature will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants