Skip to content

magento/magento2#39604: Fixed error with script (404) #39677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-devops-reposync-svc merged 7 commits into from
Apr 16, 2025
Merged

magento/magento2#39604: Fixed error with script (404) #39677

magento-devops-reposync-svc merged 7 commits into from
Apr 16, 2025
+9 −9

Conversation

@BeggiNN
Copy link
Contributor

@BeggiNN BeggiNN commented Feb 28, 2025 •
edited
Loading

  • Fixed issue for error: Script error for catalogAddToCart

Description (*)

Magento version
2.4.x
Anything else that would help a developer reproduce the bug

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Error: Script error for "Magento_Catalog/js/validate-product" for admin content pagebuilder with products load #39604

Manual testing scenarios (*)

  1. Open admin menu -> content -> pages -> edit or create new page -> edit with pagebuilder -> add row/column -> add products 2. from sidebar and choose your conditions
  2. save
  3. reopen with pagebuilder
  4. console does not have errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@BeggiNN
magento#39604: Fixed error with script (404)
c6b4e4b 
- Fixed issue for error: Script error for `catalogAddToCart`
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2025

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Feb 28, 2025

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 28, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Feb 28, 2025

@magento run all tests

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 4, 2025

@magento run Unit Tests, WebAPI Tests, Integration Tests, Functional Tests EE, Functional Tests B2B, Database Compare

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 5, 2025

@magento run Integration Tests, Functional Tests EE, Functional Tests B2B

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 6, 2025

@magento run Functional Tests EE, Functional Tests B2B

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 11, 2025

@magento run Functional Tests B2B

1 similar comment
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 12, 2025

@magento run Functional Tests B2B

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Mar 13, 2025
@Priyakshic Priyakshic moved this to Pending Review in Community Dashboard Mar 13, 2025
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 18, 2025

@magento run Functional Tests B2B

1 similar comment
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Mar 25, 2025

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Apr 2, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Apr 2, 2025
engcom-Hotel
engcom-Hotel requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BeggiNN,

The changes looks good to me. Below some changes suggested, please do the needful.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Apr 2, 2025
@engcom-Hotel engcom-Hotel moved this from Changes Requested to Pending Review in Community Dashboard Apr 2, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Apr 3, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel moved this from Pending Review to Ready for Testing in Community Dashboard Apr 3, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 4, 2025
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Apr 4, 2025

@magento run all tests

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Apr 4, 2025

Hi @BeggiNN,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Open admin menu -> content -> pages -> edit or create new page -> edit with pagebuilder -> add row/column -> add products 2. from sidebar and choose your conditions
  • save
  • reopen with pagebuilder
  • console does not have errors

Before: ✖️ 

Screenshot 2025-04-04 at 1 38 12 pm

After: ✔️

Screenshot 2025-04-04 at 1 53 17 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 4, 2025
@engcom-Charlie engcom-Charlie self-assigned this Apr 4, 2025
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 4, 2025

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 7, 2025

The Functional B2B and EE failures are not consistent in recent 2 builds on the same code. They are neither part of this PR nor failing because of the PR changes, seems to be flaky. Hence moving the PR into Merge in Progress.

Functional B2B- Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39677/8778cd9bad79c26511778a0ea529e9a3/Functional/allure-report-b2b/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39677/75df97a5305df3ed3748756f3539b0c9/Functional/allure-report-b2b/index.html#categories/49d6afa5fbaf9ef33d930e05cf5266ef/8f70c09ac184b3dd/

image

Functional EE- Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39677/760da5ea39d05da5806a9e2e62b854fa/Functional/allure-report-ee/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39677/651b37e79161132890565b8b5d5afb00/Functional/allure-report-ee/index.html#categories/b9d706eb4ea8df3f419d1b4b8a8baa79/5858ce4c238c03d6/

image

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 7, 2025
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 426f0a7 into magento:2.4-develop Apr 16, 2025
10 of 12 checks passed
@engcom-Charlie engcom-Charlie moved this from Merge in Progress to Recently Merged in Community Dashboard Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

Labels

Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community

Projects

Community Dashboard
Status: Recently Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Script error for "Magento_Catalog/js/validate-product" for admin content pagebuilder with products load

7 participants

@BeggiNN @engcom-Hotel @engcom-Bravo @engcom-Charlie @magento-devops-reposync-svc @m2-github-services @Priyakshic