Skip to content

Conversation

@Serfe-com
Copy link
Contributor

@Serfe-com Serfe-com commented Sep 12, 2024

Description (*)

We adjust the rendering of the menu and small adjustment on the contrast for the page to allow to hit 100% on accessibility on the home, PDP y PLP on Luma

Additional information: 38617

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Lighthouse Accessibility failure #39054
  2. Fixes Accessibility: WAI-ARIA roles nesting wrong in menu #35889

Manual testing scenarios (*)

  1. Load the website on the homepage with Luma
  2. Trigger a lighthouse scan enabling the accessibility scan.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2024

Hi @Serfe-com. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Sep 12, 2024
@Serfe-com
Copy link
Contributor Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2024

Hi @Serfe-com! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@Serfe-com
Copy link
Contributor Author

@magento I am working on this

@Serfe-com
Copy link
Contributor Author

@magento I am working on this

@Serfe-com
Copy link
Contributor Author

@magento run all tests

@Serfe-com
Copy link
Contributor Author

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 13, 2024
@magento-deployment-service
Copy link

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @Franciscof-Serfe, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@Serfe-com
Copy link
Contributor Author

@magento run all tests

@Serfe-com Serfe-com mentioned this pull request Sep 20, 2024
5 tasks
@Franciscof-Serfe
Copy link
Contributor

Franciscof-Serfe commented Oct 14, 2024

@magento run all tests

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Feb 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel removed the Priority: P3 May be fixed according to the position in the backlog. label Feb 19, 2025
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Serfe-com,

Thanks for the contribution!

Please fix the failed static tests.

Thanks

@Serfe-com
Copy link
Contributor Author

@magento run all tests

@Serfe-com
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @Serfe-com,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Load the website on the homepage with Luma
  • Trigger a lighthouse scan enabling the accessibility scan.

Before: ✖️ 

Screenshot 2025-02-26 at 11 56 27 am

After: ✔️

Screenshot 2025-02-26 at 12 28 42 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Dash engcom-Dash self-assigned this Mar 6, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Mar 7, 2025

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Mar 7, 2025
@Franciscof-Serfe
Copy link
Contributor

Hi Team, @engcom-Bravo @engcom-Dash @engcom-Hotel,

Would it be appropriate to label this PR as Progress: ready for testing if it has already been tested?

I've noticed that in other PRs, the Progress: accept label is applied after the Ready for Testing stage.

Could you confirm if this is the correct status?

Thank you!

Best regards,
Francisco

@engcom-Dash
Copy link
Contributor

Hi @Franciscof-Serfe We were facing some challenges with bot. I have updated the correct labels now. Thank You!!

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 0df0711 into magento:2.4-develop Apr 16, 2025
11 of 12 checks passed
@engcom-Charlie engcom-Charlie moved this from Merge in Progress to Recently Merged in Community Dashboard Apr 21, 2025
@mikakoi
Copy link

mikakoi commented Nov 26, 2025

Noticed a small problem with the pr. The pr removes data-role="content" from the content elements, but the tabs.js uses by default a selector [data-role=content] to hide the content elements when they're not active. The end result is not pretty
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

Lighthouse Accessibility failure Accessibility: WAI-ARIA roles nesting wrong in menu

9 participants