Improved date format in js console: switch from 12 hour to 24 hour fo… #38972

hostep · 2024-07-24T18:47:23Z

…rmat and adding timezone at the end.

Description (*)

When an error message is outputted to the js console, it displays a timestamp in front of it.
For example:

One of the problems I'm noticing with this, is that it shows the time in 12 hour format, which means that if you work in the evening, it will look like a time in the morning. I know this is an European thing, but even in the USA, there was no am/pm output, so over there you also have no idea if the time was before or after the noon.

Also additionally, I think it's useful to also add the timezone to this timestamp. In case you have some visitor taking screenshots of the console, you have some idea of when exactly the problem happened, and having the correct timezone will help with that.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Wait until after the noon
Manually introduce a bug in the code: open the file app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js and add this problematic line:

--- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
+++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
@@ -13,6 +13,8 @@ define([
     'use strict';

     return Component.extend({
+        problem: window.unexistingProp.unexistingProp,
+
         /**
          * @param {*} price
          * @return {*|String}

Have a Magento shop setup with at least one saleable product in the database
On the frontend, put the product in your cart and go to the checkout
Look at your browsers inspector

Before the changes, it outputs something like: [2024-07-24 07:43:24]
After the changes, it outputs something like: [2024-07-24 19:43:24+02:00]

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Improved date format in js console: switch from 12 hour to 24 hour fo… #38983: Improved date format in js console: switch from 12 hour to 24 hour fo…

…rmat and adding timezone at the end.

m2-assistant · 2024-07-24T18:47:26Z

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

hostep · 2024-07-24T18:48:14Z

@magento run all tests

engcom-Hotel · 2024-07-29T13:41:26Z

@magento create issue

engcom-November · 2024-09-19T12:54:32Z

Thanks for the collaboration & contribution!

✔️ QA Passed

Steps to reproduce:

Wait until after the noon
Manually introduce a bug in the code: open the file app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js and add this problematic line:

--- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
+++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
@@ -13,6 +13,8 @@ define([
     'use strict';

     return Component.extend({
+        problem: window.unexistingProp.unexistingProp,
+
         /**
          * @param {*} price
          * @return {*|String}

Have a Magento shop setup with at least one saleable product in the database
On the frontend, put the product in your cart and go to the checkout
Look at your browsers inspector

Before: ✖️

After: ✔️

Since there are build failures moving this to Extended testing.

engcom-Dash · 2024-09-19T13:00:02Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

engcom-Dash · 2024-09-19T15:50:16Z

@magento run Functional Tests B2B

engcom-Dash · 2024-09-20T05:31:07Z

The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38972/aa64ca23bd4bd6a275e2a01d5af6cb00/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/9fcaf8ef44683049/

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38972/5efa4e3449074d448fa381025b2e4f1e/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

…ssages

engcom-Dash · 2024-09-20T07:25:36Z

@magento run all tests

Improved date format in js console: switch from 12 hour to 24 hour fo…

fa6ae7e

…rmat and adding timezone at the end.

m2-community-project bot added the Progress: pending review label Jul 24, 2024

ihor-sviziev approved these changes Jul 25, 2024

View reviewed changes

m2-community-project bot assigned ihor-sviziev Jul 25, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Jul 25, 2024

engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 26, 2024

m2-assistant bot mentioned this pull request Jul 29, 2024

[Issue] Improved date format in js console: switch from 12 hour to 24 hour fo… #38983

Closed

5 tasks

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 29, 2024

engcom-November self-assigned this Sep 19, 2024

engcom-November added Progress: extended testing and removed Progress: ready for testing labels Sep 19, 2024

engcom-Dash self-assigned this Sep 19, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Sep 19, 2024

Merge branch '2.4-develop' into improved-date-format-of-js-console-me…

2fc5ca5

…ssages

magento-devops-reposync-svc merged commit daaa4b3 into magento:2.4-develop Dec 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improved date format in js console: switch from 12 hour to 24 hour fo… #38972

Improved date format in js console: switch from 12 hour to 24 hour fo… #38972

Uh oh!

hostep commented Jul 24, 2024 •

edited by m2-assistant bot

Loading

Uh oh!

m2-assistant bot commented Jul 24, 2024

Uh oh!

hostep commented Jul 24, 2024

Uh oh!

engcom-Hotel commented Jul 29, 2024

Uh oh!

engcom-November commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 20, 2024 •

edited

Loading

Uh oh!

engcom-Dash commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Improved date format in js console: switch from 12 hour to 24 hour fo… #38972

Improved date format in js console: switch from 12 hour to 24 hour fo… #38972

Uh oh!

Conversation

hostep commented Jul 24, 2024 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Jul 24, 2024

Uh oh!

hostep commented Jul 24, 2024

Uh oh!

engcom-Hotel commented Jul 29, 2024

Uh oh!

engcom-November commented Sep 19, 2024

✔️ QA Passed

Before: ✖️

After: ✔️

Uh oh!

engcom-Dash commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 19, 2024

Uh oh!

engcom-Dash commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hostep commented Jul 24, 2024 •

edited by m2-assistant bot

Loading

engcom-Dash commented Sep 20, 2024 •

edited

Loading