-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix dom observer not calling all listeners (regression) #38623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dom observer not calling all listeners (regression) #38623
Conversation
|
Hi @thlassche. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@thlassche wasn't it fixed in #38276 ? |
|
@magento run all tests |
|
@magento run all tests |
|
@magento give me test instance |
|
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
|
Hi @engcom-Bravo, here is your Magento Instance: https://16dd4518b17f0dfee16359646226dbfd.instances-prod.magento-community.engineering |
|
Hi @thlassche, Thanks for the collaboration & contribution! ✔️ QA Passed Preconditions:
Steps to reproduce
Before: ✖️
After: ✔️
Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
|
@magento run all tests |
|
@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,WebAPI Tests,Integration Tests |
|
@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,Integration Tests,WebAPI Tests |
|
@magento run all tests |
|
Functional Test B2B, Functional Test CE, Functional Test EE contain known failures. Hence Moving it to merge in Progress |
|
This critical bug is still present in Magento 2.4.7-p4 |
|
@maluda259, it was added to 2.4.8-beta1 and 2.4.8-beta2. |
|
No one has appeared to mention, Fixed via QPT ACSD-64467 |
|
I just don't understand how these sort of bugs keep on getting introduced into Magento releases. Everytime we upgrade, we are faced with the pain of having to work out why random functionality stops working properly, and it's bad for business and bad for reputation. QA testing needs to be significantly improved imho. |



Description (*)
A change in
dom-observer.jsin 5b931fe changed the logic, making it only call the first listener instead of all listeners. This leads to unexpected behaviourThe
returnhere now exits the loop early, which wasn't the case before, since it was inside a_function before: 5b931fe#diff-844cfb7b272693bacaa64be3a0fd96a543cc145b478330777c39682cc15b5961R152Fixed Issues (if relevant)
Related Pull Requests
https://github.com/magento-gl/magento2-page-builder/pull/77
Contribution checklist (*)