Skip to content

Conversation

@thlassche
Copy link
Contributor

@thlassche thlassche commented Apr 16, 2024

Description (*)

A change in dom-observer.js in 5b931fe changed the logic, making it only call the first listener instead of all listeners. This leads to unexpected behaviour

The return here now exits the loop early, which wasn't the case before, since it was inside a _ function before: 5b931fe#diff-844cfb7b272693bacaa64be3a0fd96a543cc145b478330777c39682cc15b5961R152

Fixed Issues (if relevant)

  1. Fixes Category description WYSIWYG is empty on non default storeview #38622

Related Pull Requests

https://github.com/magento-gl/magento2-page-builder/pull/77

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2024

Hi @thlassche. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 16, 2024

@thlassche wasn't it fixed in #38276 ?
Ah, looks like we had a similar fix in #38537

@ihor-sviziev ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 16, 2024
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento give me test instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@engcom-Bravo
Copy link
Contributor

Hi @thlassche,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Edit category in the backend on storeview level
  • Untick the box 'Use default value' next to the category description field WYSWYG editor
  • Enter a description in the WYSIWYG editor
  • Save

Before: ✖️ 

Screenshot 2024-04-17 at 09 56 03

After: ✔️  

Screenshot 2024-04-17 at 11 53 42 Screenshot 2024-04-17 at 11 54 20

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,WebAPI Tests,Integration Tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B,Integration Tests,WebAPI Tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Functional Test B2B, Functional Test CE, Functional Test EE contain known failures.
Below is the list of known failure along with the Internal JIRA.
ACQE-6487 - StorefrontSelectedByQueryParamsConfigurableOptionsThumbImagesTest
ACQE-6590 - AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
ACQE-6423 - ApplyTaxesAndFptForSimpleProductWithCanadianPstOriginTest
ACQE-5677 - StorefrontQuoteCanBeRenamedUntilLockedTest

Hence Moving it to merge in Progress

@maluda259
Copy link

This critical bug is still present in Magento 2.4.7-p4
It's been almost a year and this serious issue has not been merged to latest version yet.

@ihor-sviziev
Copy link
Contributor

@maluda259, it was added to 2.4.8-beta1 and 2.4.8-beta2.
I'm not sure if it will be ported to 2.4.7 since it should receive the only security updates

@DomPixie
Copy link
Contributor

No one has appeared to mention, Fixed via QPT

ACSD-64467

https://github.com/magento/quality-patches/blob/master/patches/os/ACSD-64467_2.4.7-p3.patch

@hewgim
Copy link

hewgim commented Nov 3, 2025

I just don't understand how these sort of bugs keep on getting introduced into Magento releases. Everytime we upgrade, we are faced with the pain of having to work out why random functionality stops working properly, and it's bad for business and bad for reputation. QA testing needs to be significantly improved imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category description WYSIWYG is empty on non default storeview

9 participants