Accessibility: WAI-ARIA roles nesting wrong in menu #38617

mirianfalconi · 2024-04-14T15:44:40Z

Fixed Issues (if relevant)

Fixes [Issue] Accessibility: WAI-ARIA roles nesting wrong in menu #40045

Manual testing scenarios (*)

Open the Lighthouse and do the Accessibily analysis without this PR

Open the Lighthouse and do the Accessibily analysis with this PR

Resolved issues:

resolves [Issue] Accessibility: WAI-ARIA roles nesting wrong in menu #40045: Accessibility: WAI-ARIA roles nesting wrong in menu

m2-assistant · 2024-04-14T15:44:43Z

Hi @mirianfalconi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

mirianfalconi · 2024-04-14T15:52:17Z

@magento run all tests

Franciscof-Serfe · 2024-05-09T16:36:55Z

app/code/Magento/Theme/Block/Html/Topmenu.php


            $html .= '<li ' . $this->_getRenderedMenuItemAttributes($child) . '>';
-            $html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . '><span>' . $this->escapeHtml(
+            $html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml(


Suggested change

$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml(

$html .= '<a href="' . $child->getUrl() . '" '

. $outermostClassCode

. ' role="menuitem"><span>'

. $this->escapeHtml(

To fix coding standard:

FILE: /var/www/html/app/code/Magento/Theme/Block/Html/Topmenu.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

249 | WARNING | Line exceeds 120 characters; contains 129 characters

mirianfalconi · 2024-05-13T13:51:08Z

@magento run all tests

mirianfalconi · 2024-05-13T20:20:57Z

@magento run all tests

Franciscof-Serfe · 2024-09-11T13:50:52Z

@magento give me test instance

magento-deployment-service · 2024-09-11T13:50:56Z

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2024-09-11T13:57:29Z

Hi @Franciscof-Serfe, here is your Magento Instance: https://186102f3462c95ef8679028b19122c14.instances-prod.magento-community.engineering
Admin access: https://186102f3462c95ef8679028b19122c14.instances-prod.magento-community.engineering/admin_ea86
Login: 3ca5520b
Password: 972f89ea79cb

Franciscof-Serfe · 2024-09-11T14:24:54Z

engcom-Hotel · 2025-06-30T08:51:25Z

@magento run all tests

engcom-Hotel

Hello @mirianfalconi,

Thanks for the collaboration!

The changes seems good to us. But please fix the failed static tests.

Thanks

engcom-Dash · 2025-07-09T10:19:11Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

engcom-Dash · 2025-07-09T13:05:22Z

The consistent Functional B2B Tests failure is known issue and Jira has been raised for the same. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/303e929bf9415c637363a3102324ffc8/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/4979a069a59cfa0051c3748ef715e0fc/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287

Hence moving this PR in Merge In Progress.

engcom-Charlie · 2025-07-28T08:30:54Z

@magento run all tests

engcom-Charlie · 2025-07-28T08:32:32Z

The PR was giving failures on copyright in mainline PR, hence moving it to Extended Testing.

engcom-Charlie · 2025-07-28T08:33:29Z

Updated the copyright year.

engcom-Charlie · 2025-07-28T08:33:43Z

@magento run all tests

engcom-Charlie · 2025-07-28T08:47:11Z

@magento run all tests

magento-automated-testing · 2025-07-28T08:47:24Z

Failed to run the builds. Please try to re-run them later.

mirianfalconi · 2025-07-28T20:26:12Z

@magento run all tests

engcom-Charlie · 2025-07-29T05:05:08Z

@magento run all tests

engcom-Charlie · 2025-07-29T08:49:16Z

@magento run all tests

engcom-Charlie · 2025-07-29T13:08:01Z

@magento run Static Tests

engcom-Charlie · 2025-07-30T05:00:24Z

@magento run all tests

engcom-Charlie · 2025-07-30T09:34:34Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

engcom-Charlie · 2025-07-30T14:26:14Z

@magento run Functional Tests B2B, Functional Tests CE, Integration Tests, WebAPI Tests

engcom-Charlie · 2025-07-31T05:50:35Z

@magento run Functional Tests B2B

engcom-Charlie · 2025-07-31T09:10:48Z

One Functional B2B test failure is consistent in recent 2 builds and its a known issue. Rest of the failures are neither part of PR now failing because of this PR changes.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/82ee0fb5e04e040b6bae3946521c9ed0/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38617/88c8c380c3f3135b8679bb88b0357812/Functional/allure-report-b2b/index.html#categories/6759f0a4e1529a056bf838dd27da1967/7ef1d58bcc955c23/

Known Issue:
ACQE-8335: AdminChangeAllCustomersGroupViaGridTest

The Integration failure is a known issue. Hence moving this PR to Merge in Progress.

Known issue:
AC-15240

Accessibility: WAI-ARIA roles nesting wrong in menu

40a7570

m2-community-project bot added the Progress: pending review label Apr 14, 2024

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 16, 2024

Franciscof-Serfe reviewed May 9, 2024

View reviewed changes

m2-community-project bot assigned Franciscof-Serfe May 9, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels May 9, 2024

Fix Category Unit Tests

2301f12

Fix Standard tests

1d3b451

Serfe-com mentioned this pull request Sep 12, 2024

Allow Lighthouse scan to reach 100% Accessibility on Homepage #39164

Merged

5 tasks

sinhaparul added the Project: Community Picked PRs upvoted by the community label Jun 10, 2025

engcom-Dash added this to Community Dashboard Jun 12, 2025

engcom-Dash moved this to Pending Review in Community Dashboard Jun 12, 2025

ct-prd-projects-boards-automation bot added the Progress: pending review label Jun 12, 2025

Merge branch '2.4-develop' into magento#35889

500dfcd

engcom-Hotel self-requested a review June 30, 2025 11:35

engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Jun 30, 2025

ct-prd-projects-boards-automation bot removed the Progress: pending review label Jun 30, 2025

engcom-Hotel requested changes Jun 30, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Jun 30, 2025

ct-prd-projects-boards-automation bot added the Progress: needs update label Jun 30, 2025

engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jul 9, 2025

engcom-Dash removed the Progress: ready for testing label Jul 9, 2025

engcom-Charlie self-assigned this Jul 28, 2025

Updated the copyright

1d293c7

engcom-Charlie moved this from Merge in Progress to Extended testing (optional) in Community Dashboard Jul 28, 2025

Merge branch '2.4-develop' into magento#35889

6dc6216

Updated copyright

d1c3f5d

Updated copyright

4a944ee

Updated copyright

2bdf70a

engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jul 31, 2025

magento-devops-reposync-svc merged commit b8cc640 into magento:2.4-develop Aug 4, 2025
10 of 12 checks passed

ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Community Dashboard Aug 4, 2025

hostep mentioned this pull request Sep 24, 2025

Luma Home page creating google pagespeed accessibility errors #40200

Closed

5 tasks

Accessibility: WAI-ARIA roles nesting wrong in menu #38617

Accessibility: WAI-ARIA roles nesting wrong in menu #38617

Uh oh!

Conversation

mirianfalconi commented Apr 14, 2024 • edited by engcom-Bravo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues (if relevant)

Manual testing scenarios (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 14, 2024

Uh oh!

mirianfalconi commented Apr 14, 2024

Uh oh!

Franciscof-Serfe May 9, 2024

Choose a reason for hiding this comment

Uh oh!

mirianfalconi commented May 13, 2024

Uh oh!

mirianfalconi commented May 13, 2024

Uh oh!

Franciscof-Serfe commented Sep 11, 2024

Uh oh!

magento-deployment-service bot commented Sep 11, 2024

Uh oh!

magento-deployment-service bot commented Sep 11, 2024

Uh oh!

Franciscof-Serfe commented Sep 11, 2024

Uh oh!

engcom-Hotel commented Jun 30, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Dash commented Jul 9, 2025

Uh oh!

engcom-Dash commented Jul 9, 2025

Uh oh!

engcom-Charlie commented Jul 28, 2025

Uh oh!

engcom-Charlie commented Jul 28, 2025

Uh oh!

engcom-Charlie commented Jul 28, 2025

Uh oh!

engcom-Charlie commented Jul 28, 2025

Uh oh!

engcom-Charlie commented Jul 28, 2025

Uh oh!

magento-automated-testing bot commented Jul 28, 2025

Uh oh!

mirianfalconi commented Jul 28, 2025

Uh oh!

engcom-Charlie commented Jul 29, 2025

Uh oh!

engcom-Charlie commented Jul 29, 2025

Uh oh!

engcom-Charlie commented Jul 29, 2025

Uh oh!

engcom-Charlie commented Jul 30, 2025

Uh oh!

engcom-Charlie commented Jul 30, 2025

Uh oh!

engcom-Charlie commented Jul 30, 2025

Uh oh!

engcom-Charlie commented Jul 31, 2025

Uh oh!

engcom-Charlie commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mirianfalconi commented Apr 14, 2024 •

edited by engcom-Bravo

Loading