Hi @DanieliMi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

This problem has also happened to me.

Thanks for the solution @DanieliMi

But I think the process itself should be rewritten here.
Why does it save customer entitiy before performing address validation?

The address validation is tightly coupled with customer address saving process in here \Magento\Customer\Model\ResourceModel\Address::_validate

We should somehow move/copy it from there and perform before we do any savings

What do you think?

Alright, here is the fix for my use case

We have customer address fields within a registration form, so we receive this error when the address is invalid.

So I created a little plugin that validates the address BEFORE Magento saves anything

<?php

declare(strict_types=1);

namespace Vendor\CustomerAddress\Plugin\Account;

use Magento\Customer\Api\AccountManagementInterface;
use Magento\Customer\Api\Data\AddressInterface;
use Magento\Customer\Api\Data\CustomerInterface;
use Magento\Framework\Validator\Exception;
use Magento\Framework\Validator\Factory;

class ValidateAddressBeforeRegistrationPlugin
{
    public function __construct(private readonly Factory $validatorFactory)
    {
    }

    /**
     * @throws Exception
     */
    public function beforeCreateAccountWithPasswordHash(
        AccountManagementInterface $subject,
        CustomerInterface $customer
    ): null {
        foreach ($customer->getAddresses() ?? [] as $address) {
            $this->validateAddress($address);
        }

        return null;
    }

    /**
     * @throws Exception
     */
    private function validateAddress(AddressInterface $address): void
    {
        $validator = $this->validatorFactory->createValidator('customer_address', 'save');

        if (!$validator->isValid($address)) {
            throw new Exception(null, null, $validator->getMessages());
        }
    }
}

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <type name="Magento\Customer\Api\AccountManagementInterface">
        <plugin name="vendor_validate_address_before_registration"
                type="Vendor\CustomerAddress\Plugin\Account\ValidateAddressBeforeRegistrationPlugin"/>
    </type>
</config>

@VladyslavSikailo, could you please create it as a pull request?

Yeah I agree, it would be much better to validate first, before even creating the customer! Would be awesome to replace this PR with a better solution!

Another approach could be to wrap it within a transaction.

@ihor-sviziev I am not really sure it should be merged into the core like that.

@magento run all tests

Hi @engcom-Hotel, I have extracted the new code into a separate method which should fix the static tests. Do they run automatically or do I have to start them manually?

Hello @DanieliMi,

Thanks for making the changes to fix the static test failures. To run the automate test, we need to run the below command manually:

@magento run all tests

@magento run all tests

@magento run all tests

@magento run all tests

@magento create issue

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

Hi @DanieliMi,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenarios

• Enable address form in customer registration in customer_account_create.xml:

<referenceBlock name="customer_form_register">
    <arguments>
        <argument name="show_address_fields" xsi:type="boolean">true</argument>
    </arguments>
</referenceBlock>

• Go to /customer/account/create/
• Fill in the form
• Remove an required address field
• Send the form

Before: ✖️

After: ✔️

Now Deletion is Possible and customer can register again successfully.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

@magento run Functional Tests CE

@magento run Functional Tests B2B

The consistent failures in Functional B2B, EE, and CE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

B2B
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/4608a90fa507db96f3f2f2be83ada2e0/Functional/allure-report-b2b/index.html

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/a736a529f8313e1a50b1d8619909c86e/Functional/allure-report-b2b/index.html

Known Issue
StorefrontGuestCreateOrderWithConfigurableProductCustomStockTest ACQE-8846
StorefrontGuestCreateOrderWithBundleProductCustomStockTestACQE-8845
StorefrontGuestCreateOrderWithGroupedProductCustomStockTest ACQE-8847
StorefrontReviewAndPaymentPageWithSimpleProductCustomStockTest ACQE-8852

EE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/d17f50ad313a0b9f22b8017d02936167/Functional/allure-report-ee/index.html

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/964970fead8871fc182544e1bc1f0cc2/Functional/allure-report-ee/index.html

Known Issue
AdminRmaSettingsConfigurationTest ACQE-8655
StorefrontGuestCreateOrderWithConfigurableProductCustomStockTest ACQE-8846
StorefrontGuestCreateOrderWithBundleProductCustomStockTestACQE-8845
StorefrontGuestCreateOrderWithGroupedProductCustomStockTest ACQE-8847
StorefrontReviewAndPaymentPageWithSimpleProductCustomStockTest ACQE-8852

CE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/96e719336f306cc95eea0adc1196ff99/Functional/allure-report-ce/index.html

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38462/a18e54dd69512246d34a3259c35a7c40/Functional/allure-report-ce/index.html

Known Issue
StorefrontGuestCreateOrderWithConfigurableProductCustomStockTest ACQE-8846
StorefrontGuestCreateOrderWithBundleProductCustomStockTestACQE-8845
StorefrontGuestCreateOrderWithGroupedProductCustomStockTest ACQE-8847
StorefrontReviewAndPaymentPageWithSimpleProductCustomStockTest ACQE-8852

Hence, Moving this PR to Merge In Progress