Skip to content

Conversation

@CreamDevelopment
Copy link

Description

Improvement: Added additional marketing tags to be excluded in Varnish configuration

Fixed Issues (if relevant)

  1. Fixes Varnish configuration does not exclude all marketing parameters #38298

Manual testing scenarios

  1. Go into the admin and export the varnish configuration to show the extra marketing tags to be excluded.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2023

Hi @CreamDevelopment. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ihor-sviziev
Copy link
Contributor

@CreamDevelopment, please sign CLA

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 21, 2023
@CreamDevelopment
Copy link
Author

@ihor-sviziev It has bene signed.

@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 22, 2023
@hostep
Copy link
Contributor

hostep commented Jan 3, 2024

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 3, 2024

@hostep I do agree, but we also have a separate fixes for that in #35228, so I would just test these 2 Pull Requests together

@peterjaap
Copy link
Contributor

@hostep @CreamDevelopment @ihor-sviziev maybe we can add a configuration field for this?

@ihor-sviziev
Copy link
Contributor

@peterjaap, I think it would be too complicated. I think having it like that should be enough

@engcom-Delta engcom-Delta added the Project: Community Picked PRs upvoted by the community label Aug 16, 2024
@engcom-Charlie engcom-Charlie self-assigned this Aug 18, 2024
@engcom-Charlie
Copy link
Contributor

Hi @CreamDevelopment,

Thank you for your contribution!

We are not able to update your PR branch now as the fork is not updated. Can you please update your branch so that we can proceed further on this PR.

Thank you!

@engcom-Charlie
Copy link
Contributor

As we are unable to update the branch in order to proceed ahead as mentioned in here, closing this PR now. Please feel free to reopen once you are done with the needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Varnish configuration does not exclude all marketing parameters

8 participants