-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Improvement: Added additional marketing tags to be excluded in Varnish configuration #38302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Added additional marketing tags to be excluded in Varnish configuration #38302
Conversation
|
Hi @CreamDevelopment. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@CreamDevelopment, please sign CLA |
|
@ihor-sviziev It has bene signed. |
|
Maybe |
|
@hostep @CreamDevelopment @ihor-sviziev maybe we can add a configuration field for this? |
|
@peterjaap, I think it would be too complicated. I think having it like that should be enough |
|
Thank you for your contribution! We are not able to update your PR branch now as the fork is not updated. Can you please update your branch so that we can proceed further on this PR. Thank you! |
|
As we are unable to update the branch in order to proceed ahead as mentioned in here, closing this PR now. Please feel free to reopen once you are done with the needed. |
Description
Improvement: Added additional marketing tags to be excluded in Varnish configuration
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist (*)