Skip to content

Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic #38276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-devops-reposync-svc merged 1 commit into from
Feb 29, 2024
Merged

Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic #38276

magento-devops-reposync-svc merged 1 commit into from
Feb 29, 2024

Conversation

@Nuranto
Copy link
Contributor

@Nuranto Nuranto commented Dec 12, 2023 •
edited by m2-assistant bot
Loading

see latest comments here : #37477

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic #38305: Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic

@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2023

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 13, 2023

@magento run all tests

@magento-automated-testing
Copy link

magento-automated-testing bot commented Dec 13, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 13, 2023
@Nuranto
Copy link
Contributor Author

Nuranto commented Dec 13, 2023

@magento run Functional Tests B2B, Functional Tests CE

@magento-automated-testing
Copy link

magento-automated-testing bot commented Dec 13, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

ihor-sviziev
ihor-sviziev approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Dec 20, 2023

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 20, 2023
Closed
5 tasks
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Dec 21, 2023

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

magento-automated-testing bot commented Dec 21, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Dec 21, 2023

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to app/code/Magento/Ui/view/base/web/js/lib/view/utils/dom-observer.js
  2. Verify the fixed broken logic on After changing "foreach" to "for", the "return"

Before: ✖️ 

Screenshot 2023-12-21 at 7 52 11 PM

After: ✔️  

Screenshot 2023-12-21 at 8 01 41 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Feb 27, 2024

@magento run Semantic Version Checker

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ef65641 into magento:2.4-develop Feb 29, 2024
This was referenced Apr 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept

Projects

Pull Requests Dashboard
Status: Recently Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue] Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic

8 participants

@Nuranto @ihor-sviziev @engcom-Delta @engcom-Charlie @LeonidTomashevskyAmasty @tim-breitenstein-it @engcom-Bravo @magento-devops-reposync-svc