Skip to content

Improve Extensibility of Service URL Generation #37403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-devops-reposync-svc merged 5 commits into from
May 12, 2025
Merged

Improve Extensibility of Service URL Generation #37403

magento-devops-reposync-svc merged 5 commits into from
May 12, 2025

Conversation

@pykettk
Copy link
Member

@pykettk pykettk commented Apr 20, 2023 •
edited
Loading

Description (*)

There are some legitimate cases for wanting to customise this function. Let's encourage people to do so in a more maintainable way i.e. via plugins instead of preferences.

Fixed Issues

#37404

Manual testing scenarios (*)

  1. Create a plugin for the Magento\Store\Model\Argument\Interpreter\ServiceUrl::getServiceUrl() function
  2. Observe that the plugin code executes as expected

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve Extensibility of Service URL Generation #37404: Improve Extensibility of Service URL Generation

@pykettk
Improve Extensibility of Service URL Generation
f67baed 
There are some legitimate cases for wanting to customise this function. Let's encourage people to do so in a more maintainable way i.e. via plugins instead of preferences.
@m2-github-services m2-github-services added Partner: Youwe partners-contribution Pull Request is created by Magento Partner labels Apr 20, 2023
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2023

Hi @pykettk. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@pykettk
Copy link
Member Author

pykettk commented Apr 20, 2023

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Apr 20, 2023
Closed
5 tasks
@pykettk
Copy link
Member Author

pykettk commented Apr 20, 2023

@magento run all tests

@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 20, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Apr 21, 2023

@magento run Functional Tests B2B Integration Tests WebAPI Tests

@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 21, 2023

Failed to run the builds. Please try to re-run them later.

@pykettk
Copy link
Member Author

pykettk commented Apr 21, 2023

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 21, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Apr 24, 2023

@magento run all tests

@pykettk pykettk closed this Apr 24, 2023
@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 24, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Apr 24, 2023

Accidental closure 😅

@pykettk pykettk reopened this Apr 24, 2023
@pykettk
Copy link
Member Author

pykettk commented Apr 24, 2023

@magento run all tests

@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 24, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Apr 24, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

magento-automated-testing bot commented Apr 24, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 26, 2023
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 2, 2023
@engcom-Dash engcom-Dash self-assigned this Sep 23, 2024
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Sep 23, 2024

Hello @pykettk,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:
Install fresh Magento 2.4-develop

Steps to reproduce

  • Create a plugin for the Magento\Store\Model\Argument\Interpreter\ServiceUrl::getServiceUrl() function
  • Observe that the plugin code executes as expected

Before: ✖️
Since we can't create a plugin for a private method, it will not be triggered anyway.

After: ✔️
Plugin is triggered.
image

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Sep 23, 2024

@magento run all tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Sep 24, 2024

@magento run WebAPI Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Sep 24, 2024 •
edited
Loading

Functional test B2B failures are different in the last two runs with a known issue.
Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37403/54e5319e3bb9291a4ba0e736b23604ac/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/255c7763b07dab10/
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37403/f3505d5607660ad30fe23f2f36b29b24/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/e0b1b1f3a1efb401/
image

So moving it to merge in progress

@engcom-Dash engcom-Dash mentioned this pull request Nov 22, 2024
Merged
5 tasks
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Apr 15, 2025

@magento run all tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Apr 15, 2025

@magento run all tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Apr 15, 2025

@magento run Functional Tests B2B, Static Tests

@engcom-Dash engcom-Dash moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 16, 2025
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Apr 16, 2025

One Consistent Test Failure is a known issue and Jira has been raised for the same.

Other test failures for Functional B2B are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: Allure Report B2B

image

Build 2: Allure Report B2B

image

Known Issue: AdminCreateTemporaryUpdateProductTest ACQE-7838

Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 16, 2025
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 561d53d into magento:2.4-develop May 12, 2025
11 of 12 checks passed
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 12, 2025
@pykettk pykettk deleted the patch-1 branch May 12, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fredden fredden fredden approved these changes

@igorwulff igorwulff igorwulff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fredden fredden

@igorwulff igorwulff

@engcom-Dash engcom-Dash

Labels

Partner: Youwe partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Pull Requests Dashboard
Status: Recently Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue] Improve Extensibility of Service URL Generation

8 participants

@pykettk @engcom-Dash @fredden @igorwulff @engcom-Hotel @engcom-Lima @magento-devops-reposync-svc @m2-github-services