Skip to content

Fix typo in MIME type of JPEG images #33514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sshymko wants to merge 4 commits into from
Closed

Fix typo in MIME type of JPEG images #33514

sshymko wants to merge 4 commits into from

Conversation

@sshymko
Copy link

@sshymko sshymko commented Jul 16, 2021 •
edited by m2-assistant bot
Loading

Description (*)

There's no MIME type image/jpg, only image/jpeg regardless of whether a file extension is *.jpeg or *.jpg.

Manual testing scenarios (*)

  1. Log in to the admin panel
  2. Open Content > Pages/Blocks
  3. Edit any Page/Block
  4. Expand Content
  5. Click Insert Image...
  6. Click Upload Images > Choose Files...
  7. Select a *.jpg image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix typo in MIME type of JPEG images #37153: Fix typo in MIME type of JPEG images

@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2021

Hi @sshymko. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sshymko sshymko changed the title Fix typo in MIME type of jpeg/jpg images Fix typo in MIME type of JPEG images Jul 16, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 17, 2021

@magento run all tests

@magento-automated-testing
Copy link

magento-automated-testing bot commented Jul 17, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn self-assigned this Jul 17, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 17, 2021

@magento run Functional Tests CE

@magento-automated-testing
Copy link

magento-automated-testing bot commented Jul 17, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 17, 2021

@magento run Functional Tests CE

@magento-automated-testing
Copy link

magento-automated-testing bot commented Jul 17, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 17, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

magento-automated-testing bot commented Jul 17, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 18, 2021

Fail tests B2B not related with this changes

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 20, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

magento-automated-testing bot commented Jul 20, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jul 20, 2021
@mrtuvn mrtuvn self-requested a review July 20, 2021 04:36
mrtuvn
mrtuvn approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@mrtuvn mrtuvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good with me

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Apr 7, 2024
@engcom-Delta engcom-Delta self-assigned this Apr 8, 2024
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Apr 10, 2024

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

Log in to the admin panel
Open Content > Pages/Blocks
Edit any Page/Block
Expand Content
Click Insert Image...
Click Upload Images > Choose Files...
Select a *.jpg image

Before: ✖️ 

Screenshot 2024-04-10 at 11 23 34 AM Screenshot 2024-04-10 at 11 23 43 AM Screenshot 2024-04-10 at 11 23 53 AM Screenshot 2024-04-10 at 11 27 44 AM Screenshot 2024-04-10 at 11 27 57 AM

After: ✔️  

Screenshot 2024-04-10 at 11 28 57 AM Screenshot 2024-04-10 at 11 32 24 AM

No additional manual test case is required as this PR is fixing the MIME type of Jpeg images.

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Charlie engcom-Charlie self-assigned this Apr 12, 2024
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 12, 2024

@magento run all tests

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 12, 2024

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 12, 2024

@sshymko Thank you for your contribution!

Can you please sign the CLA.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 15, 2024

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

1 similar comment
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 15, 2024

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 15, 2024

Moving this PR to On Hold as CLA needs to be signed before proceeding ahead.

@sshymko please do the needful.

Thank you!

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Apr 30, 2024

Hi @sshymko,

In order to move further on this PR, the CLA should be signed as requested in this comment. Closing this PR now, feel free to reopen once CLA is signed.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Den4ik Den4ik Den4ik approved these changes

@mrtuvn mrtuvn mrtuvn approved these changes

Assignees

@Den4ik Den4ik

@mrtuvn mrtuvn

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

@engcom-Lima engcom-Lima

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Cms Priority: P3 May be fixed according to the position in the backlog. Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Code Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue] Fix typo in MIME type of JPEG images

8 participants

@sshymko @mrtuvn @magento-engcom-team @engcom-Lima @engcom-Delta @engcom-Charlie @Den4ik @sinhaparul