Hi @ejaz-alam. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento run all tests

@ejaz-alam thank you for creating Pull Request.
Please cover the changes with Functional Test

Hi

I am closing this PR for now as it seems like it has become stale and still needs work.

Please feel free to reopen if you wish to continue.

Thanks!

It's really sad that this one got closed as it's a quick fix for a real problem. I don't agree with the hard requirement of adding functional tests to merge it in, it should just have been accepted as is in my opinion ...

@ejaz-alam thank you for creating Pull Request.
Please cover the changes with Functional Test

@shikhamis11 , need your help in this.

@ejaz-alam: we believe your PR needs some additional changes on these 2 lines:

• https://github.com/ejaz-alam/magento2/blob/b52c7692bd47ab996b95d988ed1cfb68adc536ff/app/code/Magento/LoginAsCustomerAssistance/Model/Config.php#L45
• https://github.com/ejaz-alam/magento2/blob/b52c7692bd47ab996b95d988ed1cfb68adc536ff/app/code/Magento/LoginAsCustomerAssistance/Model/Config.php#L56

That needs to be updated to ScopeInterface::SCOPE_STORE

And the 2 lines https://github.com/ejaz-alam/magento2/blob/b52c7692bd47ab996b95d988ed1cfb68adc536ff/app/code/Magento/LoginAsCustomerAssistance/etc/adminhtml/system.xml#L10-L11 needs to also get an showInStore="1" we think.

Thanks to colleague @radu-miron-baldwin for these additional findings

@ejaz-alam: could you update this PR with these additional changes and merge the latest 2.4-develop branch in here?

@shikhamis11, @ishakhsuvarov, @ihor-sviziev: can we get this PR re-opened? So it can be further processed?

Hi @ejaz-alam. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@magento run all tests

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento run all tests

Hi @ejaz-alam,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• In back office > Stores > Configuration >Customers > Login as Customer
• Look at the scope for fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip"

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE

The Functional CE and B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/918b288898581e9c8d4351e9607cc8a5/Functional/allure-report-ce/index.html#categories/e8b15f8cfbd42aece12f3c623e953271/a51d51ca088dffd8/

Run2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/23ec9f755ddfb617eb8d7ed74fa1f82b/Functional/allure-report-ce/index.html#categories/a644910ae0cb11e839a98baa21929b76/b0f43dc304044e0d/

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/b02ff02c241075cbd8d79dde57ad8508/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/a7c0cbfbaa73975f/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/47915016be5edb20ee2611a13e7c01cb/Functional/allure-report-b2b/index.html#categories/e8b15f8cfbd42aece12f3c623e953271/d701eee54050f3c6/

We have seen static failures in mainline PR after merging this PR into that. Hence for now moving this PR to Extended testing.

@magento run all tests

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

The Functional B2B, CE and EE test failures seem flaky and some of these failures are known issues. They are neither part of PR nor failing because of PR changes. Hence moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/a25c5eba96c358b4e4c884c5239e7a78/Functional/allure-report-b2b/index.html#categories/3a3a8306986cbb01e5245b23e6e5b238/49c7f4be9d0b368d/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/95bd338181619adb0a0b2f0fe3fccc97/Functional/allure-report-b2b/index.html#categories/3a3a8306986cbb01e5245b23e6e5b238/bf2484d30040d84/

Known issues:
MultiShippingWithCreationNewCustomerAndAddressesDuringCheckoutTest: ACQE-7229
StorefrontReuseCouponCodeAfterOrderCanceledTest: ACQE-7230

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/b9b79a4a8609689e4cda6bedb93b130c/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/8ab88db15c3ccabf/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/2e36b03a5f02a80e9b2708f0064b459d/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/c1b7c873ecb2f74f/

Known issue:
VerifyDefaultWYSIWYGToolbarOnProductTest: ACQE-7227

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/4279d8487abbec3bc3bb4331eac2a133/Functional/allure-report-ee/index.html#categories/31e33462b229a28e4a84c08a342e2286/5d51597993d437a4/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32359/0f253f3a9a35e30f455f7370e7627fb2/Functional/allure-report-ee/index.html#categories/f2aefafc67ccd17a06c2ace41fd8e7ad/bbcba68aa4752d68/