Remove HasStableHash requirement from NSSet and NSDictionary#626
Merged
Remove HasStableHash requirement from NSSet and NSDictionary#626
HasStableHash requirement from NSSet and NSDictionary#626Conversation
madsmtm
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in an abundance of caution in #505 to fix #337, but prevents real-world usage of these types, and isn't actually needed for soundness (the documentation mentions the collection being "corrupt" if the hash is changed, but that's not the same as it being UB).
This is checked with a fuzzing test (first commit) that I've run under AFL++ for ~4 hours with 6 parallell processes.
Fixes #507 (as it's no longer relevant).
Part of #563.