Fix CC logic in configure#607
Closed
thesamesam wants to merge 1 commit intomadler:developfrom
thesamesam:configure-cc
Closed
Fix CC logic in configure#607thesamesam wants to merge 1 commit intomadler:developfrom thesamesam:configure-cc
thesamesam wants to merge 1 commit intomadler:developfrom
thesamesam:configure-cc
Conversation
thesamesam
referenced
this pull request
Mar 28, 2022
Author
In e9a52aa, the logic was changed to try check harder for GCC, but it dropped the default setting of cc=${CC}. It was throwing away any pre-set CC value as a result. The rest of the script then cascades down a bad path because it's convinced it's not GCC or a GCC-like compiler. This led to e.g. misdetection of inability to build shared libs for say, multilib cases (w/ CC being one thing from the environment being used for one test (e.g. x86_64-unknown-linux-gnu-gcc -m32 and then 'cc' used for shared libs (but missing "-m32"!)). Obviously just one example of how the old logic could break. This restores the old default of 'CC' if nothing overrides it later in configure. Bug: https://bugs.gentoo.org/836308 Signed-off-by: Sam James <[email protected]>
pld-gitsync
pushed a commit
to pld-linux/zlib
that referenced
this pull request
Mar 28, 2022
|
I can confirm that this PR solve #608 |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 28, 2022
Include fixes from upstream PRs: madler/zlib#607 madler/zlib#599
|
This also fixes the compilation of dynamic library in macOS. |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 28, 2022
Include fixes from upstream PRs: madler/zlib#607 madler/zlib#599
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 28, 2022
Include fixes from upstream PRs: madler/zlib#607 madler/zlib#599
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 28, 2022
Include fixes from upstream PRs: madler/zlib#607 madler/zlib#599
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 28, 2022
Include fixes from upstream PRs: madler/zlib#607 madler/zlib#599
Closed
Owner
|
See 05796d3 . |
Author
|
Thanks. |
|
@madler: It is not possible to merge PRs than close? |
Owner
|
Not sure how. |
Author
I use pram usually (e.g.
(github has its own merge buttons but I don't usually use those as the repo isn't always hosted on github directly, just a mirror.) |
github normally have a green "merge" button, if you don't care about the merge commits. Otherwise a shortcut of @thesamesam's suggestion: |
|
A convenient way also provided by https://github.com/leahneukirchen/git-merge-pr :) |
Mindavi
added a commit
to Mindavi/nixpkgs
that referenced
this pull request
Apr 5, 2022
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3
Mindavi
added a commit
to Mindavi/nixpkgs
that referenced
this pull request
Apr 5, 2022
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3
13 tasks
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 7, 2022
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3 (cherry picked from commit f091c0e)
thefloweringash
pushed a commit
to thefloweringash/nixpkgs
that referenced
this pull request
Apr 8, 2022
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3 (cherry picked from commit f091c0e)
Closed
7c6f434c
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 2, 2022
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3 (cherry picked from commit f091c0e)
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Jul 13, 2023
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3 (cherry picked from commit f091c0e)
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Jul 21, 2023
Apply patch that already has been applied upstream: - madler/zlib#607 - madler/zlib@05796d3 (cherry picked from commit f091c0e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In e9a52aa,
the logic was changed to try check harder for GCC, but it dropped
the default setting of cc=${CC}. It was throwing away any pre-set CC value as
a result.
The rest of the script then cascades down a bad path because it's convinced
it's not GCC or a GCC-like compiler.
This led to e.g. misdetection of inability to build shared libs
for say, multilib cases (w/ CC being one thing from the environment being used
for one test (e.g. x86_64-unknown-linux-gnu-gcc -m32 and then 'cc' used for
shared libs (but missing "-m32"!)). Obviously just one example of how
the old logic could break.
This restores the old default of 'CC' if nothing overrides it later
in configure.
Bug: https://bugs.gentoo.org/836308
Signed-off-by: Sam James [email protected]