WIP Control static and shared linking completely independently#394
Open
Ericson2314 wants to merge 4 commits intomadler:masterfrom
Open
WIP Control static and shared linking completely independently#394Ericson2314 wants to merge 4 commits intomadler:masterfrom
Ericson2314 wants to merge 4 commits intomadler:masterfrom
Conversation
This allows for more configure options (e.g. shared only), and also in my opinion makes the code more readerable by making both work the same way, creating symmetry.
Ericson2314
force-pushed
the
orthogonal-static-shared
branch
from
80d5daa to
ed9a081
Compare
vaibhavsagar
reviewed
Dec 1, 2018
vaibhavsagar
reviewed
Dec 1, 2018
vaibhavsagar
reviewed
Dec 1, 2018
Co-Authored-By: Ericson2314 <[email protected]>
Co-Authored-By: Ericson2314 <[email protected]>
Co-Authored-By: Ericson2314 <[email protected]>
11 tasks
|
This is great, it would mean that in downstream packaging (e.g. NixOS/nixpkgs#66490) we no longer have to be careful with the fact that gives completely different results than see here. |
GerHobbelt
pushed a commit
to GerHobbelt/zlib
that referenced
this pull request
Nov 20, 2021
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for more configure options (e.g. shared only), and also in my opinion makes the code more readable by making both work the same way, creating symmetry.
CC @vaibhavsagar