Skip to content

Conversation

@elrid
Copy link
Contributor

@elrid elrid commented Oct 17, 2022

No description provided.

@madebyollin
Copy link
Owner

Thanks! I just removed Float16 in an alternate way (via cast inside the MPSGraph). Does it work on Intel now? If so, we can simplify this PR a bit (no more Accelerate) and merge it.

@elrid
Copy link
Contributor Author

elrid commented Oct 18, 2022

Yep, everything now works on intel macs:)

@@ -1,15 +1,16 @@
import MetalPerformanceShadersGraph
import Foundation
import Accelerate
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is no longer needed, right? Other than that LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah, sorry, missed it:)

@madebyollin madebyollin merged commit e1fc983 into madebyollin:main Oct 19, 2022
@madebyollin
Copy link
Owner

Merged (and I updated the README section regarding Intel support). Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants