Revert "Support guioptions 'k' flag in MacVim, prevents unnecessary w… #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow resize" This reverts commit 1333bc6. The previous change broke external monitors and zoom button. Revert the change before a proper fix can be implemented.
This was referenced Aug 10, 2018
Closed
Contributor
|
This seems like a good fix, and it works for me. I haven't looked at the CI in this repo before, but there is a failure on this commit and it makes me wonder if it's an improper test since I was able to build locally with zero turbulence. The problem with opening MacVim on a secondary monitor and seeing the window occluded is no longer present with this commit. Zooming also seems fine. |
splhack
added a commit
that referenced
this pull request
Aug 14, 2018
Binary targets macOS 10.8+ - Vim patch 8.1.0280 - Reverted guioption 'k' #727 Script interfaces have compatibility with these versions - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…indow resize"
This reverts commit 1333bc6.
The previous change broke external monitors and zoom button. Revert the
change before a proper fix can be implemented.
This reverts the change introduced in #708. I will debug this and submit a patch to re-enable guioptions-k without breaking existing functionality later.
I can confirm the zoom button works again, but have not been able to check the external monitor case yet. If someone can check that (#721) please do so before merging this pull request.
Close #721
Close #724