Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memento count is not initially fetched for the default URI #416

Closed
machawk1 opened this issue Apr 4, 2019 · 3 comments
Closed

Memento count is not initially fetched for the default URI #416

machawk1 opened this issue Apr 4, 2019 · 3 comments
Labels
bug Integration with New Archiving Tools MacOS X-Specific

Comments

@machawk1
Copy link
Owner

machawk1 commented Apr 4, 2019

This may have to do with the trigger to invoke it, which is tied to the URI text field changing.

0dae576
@machawk1
Copy link
Owner Author

machawk1 commented Apr 4, 2019

Just to verify, the "onChange" event still triggers as expected.

@machawk1
Copy link
Owner Author

machawk1 commented Apr 4, 2019

Replicable from the binary and src.

@machawk1
Copy link
Owner Author

machawk1 commented Apr 4, 2019

This seems to relate to #404 and the opposite of the intended conditional to exclude Linux from the current logic.

wail/bundledApps/WAIL.py

Lines 343 to 344 in 854c2e2

if util.is_linux(): # Issue 404
thread.start_new_thread(self.fetchMementos, ())

Reversing this logic allows the thread to be created and the default memento count fetch procedure to run.

machawk1 added a commit that referenced this issue Apr 4, 2019
@machawk1
Reverse logic for memgator communication thread spawn to exclude
dede885 
linux (for now) re:#404.

Fixes #416
@machawk1 machawk1 mentioned this issue Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Integration with New Archiving Tools MacOS X-Specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@machawk1