Sort editor theme and rendering CSS preference menus#1371
Closed
lexblagus wants to merge 1 commit into
Closed
Conversation
Use localizedStandardCompare: so Theme (Editor) and CSS (Rendering) popup lists appear in ascending order. Made-with: Cursor
3 tasks
|
Hey @lexblagus — just a heads-up that we've adopted this enhancement downstream in schuyler/macdown3000#404. Nice quality-of-life fix; thanks for putting it together! 🙏 |
schuyler
added a commit
to schuyler/macdown3000
that referenced
this pull request
Apr 26, 2026
## Summary - Sort the **Theme (Editor)** and **CSS (Rendering)** popup lists in Preferences alphabetically using `localizedStandardCompare:` so entries are easier to discover. Ported from upstream [MacDownApp/macdown#1371](MacDownApp/macdown#1371) by @lexblagus. ## Test plan - [ ] Open Preferences → Editor and confirm the Theme dropdown is sorted alphabetically (locale-aware). - [ ] Open Preferences → Rendering and confirm the CSS dropdown is sorted alphabetically. - [ ] CI build passes on macOS. --- thank you @lexblagus!
Author
That's wonderful! Appreciate the kindness! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use localizedStandardCompare: so Theme (Editor) and CSS (Rendering) popup lists appear in ascending order.
Made-with: Cursor