If the first remote locator is not located on the embeddedRTPS subnet, an incorrect deserialization failure is return, which breaks SPDP (#15)

akampmann · Alexandru Kampmann · web-flow · commit 1410a8776660 · 2022-05-06T10:18:59.000+02:00
Co-authored-by: Alexandru Kampmann &lt;kampmann@embedded.rwth-aachen.de&gt;
diff --git a/include/rtps/storages/MemoryPool.h b/include/rtps/storages/MemoryPool.h
@@ -101,6 +101,7 @@ template <class TYPE, uint32_t SIZE> class MemoryPool {
 
   bool add(const TYPE &data) {
     if (isFull()) {
+      printf("[MemoryPool] RESSOURCE LIMIT EXCEEDED \n");
       return false;
     }
     for (uint8_t bucket = 0; bucket < sizeof(m_bitMap); ++bucket) {
diff --git a/src/discovery/ParticipantProxyData.cpp b/src/discovery/ParticipantProxyData.cpp
@@ -174,17 +174,17 @@ bool ParticipantProxyData::readLocatorIntoList(
           full_length_locator.isMulticastAddress()) {
         proxy_locator = LocatorIPv4(full_length_locator);
         SPDP_LOG("Adding locator: %u %u %u %u \n",
-                 (int)proxy_locator.address[12], (int)proxy_locator.address[13],
-                 (int)proxy_locator.address[14],
-                 (int)proxy_locator.address[15]);
+                 (int)proxy_locator.address[0], (int)proxy_locator.address[1],
+                 (int)proxy_locator.address[2],
+                 (int)proxy_locator.address[3]);
         return true;
       } else {
         SPDP_LOG("Ignoring locator: %u %u %u %u \n",
                  (int)full_length_locator.address[12],
                  (int)full_length_locator.address[13],
                  (int)full_length_locator.address[14],
                  (int)full_length_locator.address[15]);
-        return false;
+        return true;
       }
     } else {
       valid_locators++;
diff --git a/src/messages/MessageTypes.cpp b/src/messages/MessageTypes.cpp
@@ -166,11 +166,6 @@ bool rtps::deserializeMessage(const MessageProcessingInfo &info,
   }
 
   if (msg.readerSNState.numBits != 0) {
-    if (4 * ((msg.readerSNState.numBits / 32) + 1) >
-        msg.readerSNState.bitMap.size()) {
-      while (1)
-        ;
-    }
     doCopyAndMoveOn(
         reinterpret_cast<uint8_t *>(msg.readerSNState.bitMap.data()),
         currentPos, 4 * ((msg.readerSNState.numBits / 32) + 1));

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ template <class TYPE, uint32_t SIZE> class MemoryPool {`
`101`	`101`
`102`	`102`	`bool add(const TYPE &data) {`
`103`	`103`	`if (isFull()) {`
	`104`	`+ printf("[MemoryPool] RESSOURCE LIMIT EXCEEDED \n");`
`104`	`105`	`return false;`
`105`	`106`	`}`
`106`	`107`	`for (uint8_t bucket = 0; bucket < sizeof(m_bitMap); ++bucket) {`