Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade repo to Go 1.18 #56

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Upgrade repo to Go 1.18 #56

merged 1 commit into from
Aug 19, 2022

Conversation

SaiedKazemi
Copy link
Member

@SaiedKazemi SaiedKazemi commented Aug 19, 2022 •
edited by stephen-soltesz
Loading

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 161

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 159: 0.0%
Covered Lines: 408
Relevant Lines: 408
💛 - Coveralls

stephen-soltesz
stephen-soltesz approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@SaiedKazemi SaiedKazemi merged commit 95f0bcf into main Aug 19, 2022
@SaiedKazemi SaiedKazemi deleted the sandbox-saied-go118 branch August 19, 2022 16:21
@goern goern mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-soltesz stephen-soltesz stephen-soltesz approved these changes

Assignees
No one assigned
Labels
fixit2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaiedKazemi @coveralls @stephen-soltesz