fix getOrgAndRepoFromIssue for enterprise #45
Conversation
There was a problem hiding this comment.
lgtm with an extra comment.
Reviewable status: 0 of 1 LGTMs obtained
issues/issues.go, line 284 at r1 (raw file):
for i := 0; i <= len(fields); i++ { if fields[i] == "repos" { if i+2 == len(fields)-1 {
Please add a comment clarifying that this is to support the difference between default and enterprise API paths.
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
issues/issues.go, line 289 at r1 (raw file):
} } return "", "", fmt.Errorf("Issue has invalid RepositoryURL path values")
Hmm, it looks like the error path is never visited, which leaves the code coverage incomplete.
Please add a new case that visits this error path, or refactor to eliminate it.
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
issues/issues.go, line 289 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
Hmm, it looks like the error path is never visited, which leaves the code coverage incomplete.
Please add a new case that visits this error path, or refactor to eliminate it.
complete! 1 of 1 LGTMs obtained
Found a bug for enterprise in getOrgAndRepoFromIssue(), which occur when labels are used. It occurs because the enterprise URL path contains /api/v3/ at the beginning.
I add some logic which reads only the two fields after the first occurred "repos"/
This change is