Add CMake option LZ4_BUILD_CLI#919
Merged
Conversation
Defaults to ON so nothing changes, but it can be set to OFF so that the CLI is not built at all, only the library.
attilaolah
pushed a commit
to attilaolah/wasm
that referenced
this pull request
Sep 23, 2020
Add an option to avoid building binaries. This works around the failure of incorrectly trying to symlink `lz4cat` and `unlz4` when the binary suffix is specified (e.g. `.js` when building with Emscripten.) Import backported modified patch from lz4/lz4#919.
Cyan4973
approved these changes
Sep 23, 2020
Member
|
Looks good ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults to
ONso nothing changes, but it can be set toOFFso that the CLI is not built at all, only the library, i.e. like so:This is useful in combination with
-DLZ4_BUILD_LEGACY_LZ4C:BOOL=OFFfor builds where only the library is needed.