Create CMake package when installing#1030
Merged
Conversation
Cyan4973
approved these changes
Oct 20, 2021
Member
|
Thanks @kostasdizas ! Looks good to me ! |
|
Thank you so much! Exactly what I needed after finding out that the CMake integration of v1.9.3 wasn't working as easily as expected. |
Tachi107
reviewed
Oct 12, 2022
| INSTALL_DESTINATION ${LZ4_PKG_INSTALLDIR}) | ||
| export(EXPORT lz4Targets | ||
| FILE ${CMAKE_CURRENT_BINARY_DIR}/lz4Targets.cmake | ||
| NAMESPACE LZ4::) |
There was a problem hiding this comment.
Why is the namespace upper case? The config file is called lz4, and exporting a namespace named differently is confusing, as it breaks the common practice used in the wider CMake ecosystem.
This also creates issues with pretty much every project who was already using lz4 in CMake, as people (quite unsurprisingly) use the lowercase lz4 namespace, and package managers like vcpkg do as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a small change to the CMake build files to create a package so it can be easily included in other projects.