Fix memory leak in template concat error handling#59
Merged
lysnikolaou merged 3 commits intolysnikolaou:tstringsfrom Apr 9, 2025
Merged
Fix memory leak in template concat error handling#59lysnikolaou merged 3 commits intolysnikolaou:tstringsfrom
lysnikolaou merged 3 commits intolysnikolaou:tstringsfrom
Conversation
lysnikolaou
reviewed
Apr 9, 2025
Owner
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
Great catch! I think the best way to go here would be for template_from_strings_interpolations to not steal references and instead call Py_NewRef itself. Then we can DECREF unconditionally in template_concat_templates and friends.
Co-authored-by: Lysandros Nikolaou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak when template concatenation fails (e.g., out of memory).
Ensures intermediate
stringsandinterpolationstuples are now properlyreleased in
template_concat_*functions.