Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a custom slide page route animation more suitable for desktop applications and systematically replaces all MaterialPageRoute usages with the new SlidePageRoute. It also removes the .vscode folder from version control.
Changes:
- Added a new
SlidePageRouteclass that provides a right-to-left slide transition animation with customizable duration (default 300ms) - Replaced all ~50 instances of
MaterialPageRoutewithSlidePageRouteacross the codebase - Applied extensive code formatting improvements (line breaks, indentation, spacing consistency)
- Removed
.vscode/settings.jsonfrom repository (already in.gitignore)
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/function/slide_page_route.dart | New custom page route with slide animation and shadow effect |
| lib/main.dart | Updated route generation to use SlidePageRoute; code formatting improvements |
| lib/pages/*.dart | Replaced MaterialPageRoute with SlidePageRoute in navigation calls |
| lib/pages/home/*.dart | Updated navigation to use SlidePageRoute; formatting improvements |
| lib/pages/setting/*.dart | Migrated all page navigations to SlidePageRoute |
| lib/pages/online.dart | Updated navigation and applied extensive formatting improvements |
| lib/pages/download/*.dart | Replaced MaterialPageRoute throughout download flow |
| .vscode/settings.json | Removed personal IDE configuration from repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
考虑下加个CONTRIBUTING.md？回头一看才发现ide给我全格式化了（） |
|
首先先是感谢提交pr :) 这是我个人的项目收到的首个pr。没有加贡献指南是因为我根本没有想到作为一个我个人学习flutter的项目(我开始写这个项目时完全是flutter新手, 从前期混乱的代码和命名也可以看出)会收到收到pr, 所以也没有去写贡献指南, 我晚点会去考虑的 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1.增加了一个从右到左滑入的路由切换动画，并将对MaterialPageRoute全部替换为了SlidePageRoute
2.使git不再追踪.vscode，.vscode文件夹为个人配置不应被上传到远程仓库中