Make support of remote in command line optional#446
Merged
Conversation
Signed-off-by: Lucas Bremgartner <[email protected]>
Member
|
@breml looks good but there's something missing I think. We currently allow one optional argument with |
Signed-off-by: Lucas Bremgartner <[email protected]>
stgraber
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Operations Center cli does not support passing the remote as command line argument. One has to explicitly switch to the desired remote and then perform the respective commands.
Without the changes in this PR, the description of the
admin oscommands do look confusing for an Operations Center CLI user, since it mentions the remote argument, which is in fact without any effect.IMPORTANT: the way, this is currently implemented, this would "break" the implementation in
incuscli, since the default (zero) value forSupportsRemoteisfalseand therefore it will remove the mention of remote inincuscli.I prefer to have these flags with "positive" names, but if we can not do the "breaking" change, then we would need to rename
SupportsRemoteto something likeWithoutRemote. Let me know, what you prefer.