Conversation
This is a small Go API break which is needed to address a security issue where we need the ability to re-hash the final image files. This is part of a fix for CVE-2026-33542. Reported-by: wl2018 Signed-off-by: Stéphane Graber <[email protected]>
This is part of a fix for CVE-2026-33542. Reported-by: wl2018 Signed-off-by: Stéphane Graber <[email protected]>
This is part of a fix for CVE-2026-33542. Reported-by: wl2018 Signed-off-by: Stéphane Graber <[email protected]>
Following download of the files/deltas, compute a full hash to make sure we have the expected image. This is part of a fix for CVE-2026-33542. Reported-by: wl2018 Signed-off-by: Stéphane Graber <[email protected]>
This fixes an issue when running on systems without the protect_symlinks kernel protection enabled (introduced in 2012). On such systems, a user could pre-create symlinks to sensitive files on the system and trick Incus into truncating them and altering their file mode and ownership. This addresses CVE-2026-33711 Reported-by: https://7asecurity.com Signed-off-by: Stéphane Graber <[email protected]>
Properly skip anything that doesn't have the expected path prefix for a file within the bucket. Then use strings.TrimPrefix rather than a fixed offset to clear the prefix. This addresses CVE-2026-33743 Reported-by: https://7asecurity.com Signed-off-by: Stéphane Graber <[email protected]>
The chroot logic in pongo2 doesn't work and therefore allows all templates to read and write to arbitrary paths on the host filesystem. Given the logic seemingly never worked properly, no template out there should be dependent on the file related functions being functional. Transition to our standard RenderTemplate logic which specifically block all file related functions. Introduces a new RenderTemplateFile to handle cases where we want to directly write to a file (useful for write quotas). This addresses CVE-2026-33897 Reported-by: https://7asecurity.com Signed-off-by: Stéphane Graber <[email protected]>
Fix the logic to validate the token both on initial use and through cookie. Also add an Origin check for good measure. This addresses CVE-2026-33898 Reported-by: https://7asecurity.com Signed-off-by: Stéphane Graber <[email protected]>
gibmat
reviewed
Mar 26, 2026
systemd credentials name could be abused to escape the credentials folder and allow for arbitrary writes to the host filesystem allowing for privilege escalation and denial of service attacks. We now use Go's OpenRoot (openat2) to restrict all file interactions to the "credentials" directory, avoiding such attacks. This addresses CVE-2026-33945 Reported-by: https://7asecurity.com Signed-off-by: Stéphane Graber <[email protected]>
hallyn
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.