Skip to content

Add cp-like flags to pull commands#3086

Merged
stgraber merged 5 commits intolxc:mainfrom
bensmrs:pull-flags
Mar 26, 2026
Merged

Add cp-like flags to pull commands#3086
stgraber merged 5 commits intolxc:mainfrom
bensmrs:pull-flags

Conversation

@bensmrs
Copy link
Copy Markdown
Contributor

@bensmrs bensmrs commented Mar 25, 2026

Closes: #3017
This also ensures files are properly closed in pull methods.

@bensmrs bensmrs force-pushed the pull-flags branch 2 times, most recently from 21464f1 to 0f41b0c Compare March 25, 2026 22:47
@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Mar 25, 2026

I’m having trouble running storage_volume_filemanip locally: Error: Failed connecting to instance SFTP: Failed getting storage volume SFTP connection: Failed to run forkfile: fork/exec /root/go/bin/incusd: permission denied:. Rings any bell, @stgraber?

@stgraber
Copy link
Copy Markdown
Member

Yeah, we probably run it with reduced privileges so you need to chmod +x all folders leading to the binary so unprivileged users can run incusd

@stgraber
Copy link
Copy Markdown
Member

chmod +x /root /root/go /root/go/bin should do it

@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Mar 25, 2026

Yep, that did it! thanks

@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Mar 26, 2026

This work needs some follow-up to implement a similar logic for push commands, but I probably won’t write it in time for this release.

@bensmrs bensmrs marked this pull request as ready for review March 26, 2026 00:52
@bensmrs bensmrs requested a review from stgraber as a code owner March 26, 2026 00:52
@stgraber stgraber merged commit 633b0f9 into lxc:main Mar 26, 2026
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

incus file pull no way to pull physical file of an instance symlink

2 participants