Conversation
|
I’ve added a small golangci exception to treat colored printers the same as |
|
FormatSection also needs some patching, it seems |
This incidentally allows translating command usage sections. Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
|
Phew, that proved a bit more painful than expected. |
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
|
@bensmrs I am a bit late on this one, but it might be worth mentioning in the docs / README, that colorized output can be disabled using CC: @stgraber |
|
Ok, will do. I’ll also add a key in the client config to disable it. |
|
I’ve got all the bits working, but I’m wondering a few things, @stgraber. |
Ah yeah, the I think for the color handling, it'd make sense to put that under And yeah, the CLI configuration doesn't really have any documentation, which is a bit of a problem on its own and something we should probably be addressing ;) |
|
Ok, I’ll patch the PR after my evening context switch |
I believe the changes don’t lead to cognitive overload, while still giving a nice pop to some elements that could benefit from it, helping to navigate through long command descriptions.
This PR also incidentally allows translating command usage sections.
Related-to: #2877
Related-to: #3040