Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Benjamin Somers <[email protected]>
…e agent Signed-off-by: Benjamin Somers <[email protected]>
stgraber
approved these changes
Mar 18, 2026
Signed-off-by: Benjamin Somers <[email protected]>
auto-merge was automatically disabled
March 19, 2026 00:51
Head branch was pushed to by a user without write access
Signed-off-by: Benjamin Somers <[email protected]>
stgraber
reviewed
Mar 19, 2026
| return err | ||
| } | ||
|
|
||
| // Sync the hostname. |
Member
There was a problem hiding this comment.
Feels like we should move that to a per-OS function instead of having all this stuff run on say Windows too ;)
Contributor
Author
There was a problem hiding this comment.
Sure. With all the os_<os>.go mess or another naming scheme, and if so, what name would you suggest? I’m really uninspired with this one.
stgraber
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.