Merged
Conversation
J0nasDotDev
changed the title
Member
|
Instead of nolint for the packages named |
Signed-off-by: Jonas Sprenger <[email protected]>
J0nasDotDev
force-pushed
the
chore/2636/golangci-lint-internal-server-util
branch
from
98f965f to
cfc2412
Compare
J0nasDotDev
commented
Mar 3, 2026
Comment on lines
+78
to
+79
| - path: internal/server/util/ | ||
| text: "avoid meaningless package names" |
Contributor
Author
There was a problem hiding this comment.
@stgraber Indeed, it's way better to adapt golangci-lint config file.
It was a rather lazy approach on my part to 'nolint' the name of the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to #2636 and address the lint issues in `internal/server/util/....