Merged
Conversation
J0nasDotDev
force-pushed
the
chore/2636/golangci-lint-internal-server-firewall
branch
from
d100b09 to
76a53ac
Compare
Member
|
Signed-off-by: Jonas Sprenger <[email protected]>
J0nasDotDev
force-pushed
the
chore/2636/golangci-lint-internal-server-firewall
branch
from
76a53ac to
71439fa
Compare
Contributor
Author
|
I added newlines after the functional blocks. Is it expected that there is no configured linter or formatter that enforces this rule? |
Member
Yeah. It's only pretty recently that wsl can handle this particular one and we haven't yet switched the check over to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to #2636 and address the lint issues in
internal/server/firewall/....