incus: Add checks before starting sshSFTPserver#2974
Merged
Conversation
3609937 to
6335141
Compare
41d7f7a to
64bfdc2
Compare
Contributor
Author
Signed-off-by: Jonas Sprenger <[email protected]>
Signed-off-by: Jonas Sprenger <[email protected]>
Signed-off-by: Jonas Sprenger <[email protected]>
64bfdc2 to
bdd4811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
incus file mountandincus storage volume file mountin SSH SFTP listener mode to fail early when the entity (instance, storage pool, or storage volume) does not exist.Previously, these commands could start the listener process even non-existent entities, resulting in confusing runtime behavior.
Resolves: #2944
Description
The
sshSFTPServerdoesn't require the entity directly as a parameter, they are used indirectly through thesftpConnlambda function.These changes try to get the entity before calling
sshSFTPServerand fail early if the entity does not exist.Note:
sftpConnis only called after an SSH connection, andsshSFTPServerdoesn't return an error ifsftpConnfails.I also updated the help texts to clarify the listener behavior when the target path is omitted.
Behavior after changes