incusd/storage/linstor: Propagate error when volume filler fails#2971
Merged
incusd/storage/linstor: Propagate error when volume filler fails#2971
Conversation
The current implementation was incorrectly suppressing errors that occurred in the filler function when creating volumes via the Linstor driver. When any error ocurred in the filler function, the reversion logic would delete the volume, but the return nil would signal to the caller that the operation succeeded, causing a "Resource definition not found" error when performing any subsequent Linstor operations on the volume. Signed-off-by: Luís Simas <[email protected]>
Contributor
Author
|
Most likely the cause to #2964 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation was incorrectly suppressing errors that
occurred in the filler function when creating volumes via the Linstor
driver.
When any error ocurred in the filler function, the reversion logic would
delete the volume, but the return nil would signal to the caller that
the operation succeeded, causing a "Resource definition not found" error
when performing any subsequent Linstor operations on the volume.
Signed-off-by: Luís Simas [email protected]