Skip to content

Fix preseed struct#2968

Merged
hallyn merged 5 commits intolxc:mainfrom
stgraber:main
Feb 24, 2026
Merged

Fix preseed struct#2968
hallyn merged 5 commits intolxc:mainfrom
stgraber:main

Conversation

@stgraber
Copy link
Copy Markdown
Member

No description provided.

YAML which is our primary user facing format has been using in-lining of
the server configuration within the preseed. But the Go and JSON side of
the struct were not set up to match, leading to a bunch of issues with
IncusOS and associated projects that frequently flip back and forth
between JSON and YAML.

To fix this properly, change the struct to reflect the way it's been
used by users since its introduction. This is technically a small
breaking change for anyone directly interacting with the struct through Go.

This isn't an actual REST API struct, so there is no impact at the REST
API level.

Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Feb 24, 2026
Copy link
Copy Markdown
Collaborator

@breml breml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallyn hallyn merged commit 017eb50 into lxc:main Feb 24, 2026
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Changes to the REST API Documentation Documentation needs updating

Development

Successfully merging this pull request may close these issues.

3 participants