incusd/device: Retry MAC address setting on SR-IOV VF interfaces#2894
Closed
incusd/device: Retry MAC address setting on SR-IOV VF interfaces#2894
Conversation
Some drivers like iavf (Intel Adaptive Virtual Function) may still be initializing after the network interface appears, causing MAC address setting to fail with EAGAIN. This adds a retry loop (up to 5 seconds) when setting the MAC address on SR-IOV VF interfaces for containers. Signed-off-by: Paul Saab <[email protected]>
Contributor
|
Please refer to |
Author
|
Ahh whoops, sorry about that. I did test this change out and it solves my issues with the ice driver.. I guess I am just looking for how we want to handle the retry loop. |
Author
|
Do we still think we can review this and get something in to fix this problem? I have tested that this works and I can now use incus with sriov on one of my machines. |
Member
|
Yeah, I'll send an equivalent PR soon. The code here looks pretty good, just not our usual style of retry loops :) |
tlusser
pushed a commit
to tlusser/incus
that referenced
this pull request
Feb 8, 2026
Closes lxc#2894 Signed-off-by: Stéphane Graber <[email protected]> Suggested-by: Paul Saab <[email protected]>
stgraber
added a commit
that referenced
this pull request
Mar 12, 2026
Closes #2894 Signed-off-by: Stéphane Graber <[email protected]> Suggested-by: Paul Saab <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iavf(Intel Adaptive Virtual Function) may still be initializing after the network interface appears, causing MAC address setting to fail withEAGAINTest plan
🤖 Generated with Claude Code