Skip to content

Add attached and connected keys to NIC devices#2847

Merged
stgraber merged 12 commits intolxc:mainfrom
bensmrs:nic-attached-connected
Jan 23, 2026
Merged

Add attached and connected keys to NIC devices#2847
stgraber merged 12 commits intolxc:mainfrom
bensmrs:nic-attached-connected

Conversation

@bensmrs
Copy link
Copy Markdown
Contributor

@bensmrs bensmrs commented Jan 22, 2026

Closes: #2780

@bensmrs bensmrs requested a review from stgraber as a code owner January 22, 2026 18:27
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 22, 2026
@bensmrs
incusd/device/nic: Add attached configuration key
fbf8b44 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/device/nic: Add connected configuration key
8c27e80 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/instance/qemu: Properly update detached devices
299db59 
This fixes a bug where modifying an updatable configuration key (for
example, `limits.read`) while the device (for example a disk) is
detached could lead the update function to ask QEMU to perform
operations on a device it doesn't know.

Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs bensmrs force-pushed the nic-attached-connected branch from f1d68b7 to 66607e7 Compare January 22, 2026 18:41
@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Jan 22, 2026

I’ll write a few tests in ~3h tops

@stgraber
Copy link
Copy Markdown
Member

stgraber commented Jan 22, 2026

Cool, static analysis is also looking a bit unhappy :)

@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Jan 22, 2026

Haven’t done any Go for a while, my reflexes are a bit rusty!

@bensmrs bensmrs force-pushed the nic-attached-connected branch from 66607e7 to 24ce2b6 Compare January 22, 2026 20:55
@bensmrs
incusd/instance/qemu: Implement NIC connected config key
189171c 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/ip/link: Relax parent detection logic
74b7cd5 
This commit fixes the fact that `LinkByName` reported a link not found
error when run on a veth pair whose other end is in a container.

Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/instance/lxc: Implement NIC connected config key
7ff5d06 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
api: nic_attached_connected
79cd4ad 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
doc: Update config
24ce2b6 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
tests: Add NIC tests for attached and connected keys
3bfc942 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
Copy link
Copy Markdown
Contributor Author

bensmrs commented Jan 22, 2026

I don’t have an OVN testbed and the test suite doesn’t test OVN, so it would be nice if you have a free testing instance with OVN to test that OVN works like the others when setting acceleration=none.

@stgraber stgraber merged commit 2591dce into lxc:main Jan 23, 2026
54 of 56 checks passed
@Shaderbug
Copy link
Copy Markdown
Contributor

Shaderbug commented Jan 31, 2026

Hi @bensmrs and @stgraber,

did the SR-IOV test changes introduced with this PR run successfully for you? They seem to be failing on my machine and I want to exclude this being a me-problem 😅

Thank you very much :)

@stgraber
Copy link
Copy Markdown
Member

stgraber commented Jan 31, 2026

Our CI doesn't have SR-IOV hardware, so INCUS_NIC_SRIOV_PARENT isn't set there.
We do have daily Jenkins SR-IOV tests and my desktop machine also supports SR-IOV but neither of them commonly et INCUS_NIC_SRIOV_PARENT either.

So it may very well be that the test in question is broken.
Please file a new issue for tracking and include the output you're getting.
We made a few changes that may have broken the test. It can also be an environmental issue depending on the card being used, but we'll figure it out.

@Shaderbug
Copy link
Copy Markdown
Contributor

Shaderbug commented Jan 31, 2026

Done, I've opened #2881 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

Assignees

No one assigned

Labels

API Changes to the REST API Documentation Documentation needs updating

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add both attached and connected properties to NIC devices

3 participants

@bensmrs @stgraber @Shaderbug