Skip to content

Hash serial value if it exceeds the maximum length#2841

Merged
stgraber merged 2 commits intolxc:mainfrom
presztak:long_serial
Jan 21, 2026
Merged

Hash serial value if it exceeds the maximum length#2841
stgraber merged 2 commits intolxc:mainfrom
presztak:long_serial

Conversation

@presztak
Copy link
Copy Markdown
Contributor

@presztak presztak commented Jan 21, 2026

Currently, when a serial number is too long, QEMU either truncates it or fails with an error.
This PR introduces hashing for device serials that exceed the allowed length, preventing issues caused by overly long serial numbers.

Closes: #2822

@presztak presztak marked this pull request as ready for review January 21, 2026 17:24
@presztak presztak requested a review from stgraber as a code owner January 21, 2026 17:24
@stgraber stgraber merged commit b258523 into lxc:main Jan 21, 2026
157 of 160 checks passed
@presztak presztak deleted the long_serial branch February 11, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Adding a disk with a device serial longer than 36 bytes fails

2 participants