Conversation
Member
|
Sorry for the delay. |
hlloreda
force-pushed
the
logs-volume-config
branch
from
c41bcec to
b6a08fa
Compare
Contributor
Author
This should be fixed, and I also modified the commit messages |
stgraber
force-pushed
the
logs-volume-config
branch
from
b6a08fa to
f0c322b
Compare
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Hugo Lloreda <[email protected]>
Signed-off-by: Hugo Lloreda <[email protected]>
Signed-off-by: Hugo Lloreda <[email protected]>
stgraber
force-pushed
the
logs-volume-config
branch
from
f0c322b to
a397c1b
Compare
Signed-off-by: Hugo Lloreda <[email protected]>
stgraber
force-pushed
the
logs-volume-config
branch
from
a397c1b to
ddbd575
Compare
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Hugo Lloreda <[email protected]>
stgraber
force-pushed
the
logs-volume-config
branch
from
ddbd575 to
03bb491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on this one: #2525
I tried to implement the missing pieces to be able to close #2484