internal/jmap: Refactor Map methods and add comprehensive tests#2765
Merged
internal/jmap: Refactor Map methods and add comprehensive tests#2765
Conversation
Member
|
Missing Signed-off-by line in the commit message |
Changes: - Use early return where needed. - Add missing docstrings. - Fix typo in error. - Add missing unit tests for jmap. Signed-off-by: Denys Mosiiuk <[email protected]>
dector
force-pushed
the
ref/2636/fix-lint-internal-jmap
branch
from
b810f43 to
045bee7
Compare
Contributor
Author
|
Fixed, sorry for that. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: