Closed
Conversation
Signed-off-by: Leon Schoch <[email protected]>
…tion Signed-off-by: Leon Schoch <[email protected]>
…nic_ovn Signed-off-by: Leon Schoch <[email protected]>
Unfortunately we cannot only store them in the ovn northbound db, as individual qos rules can only be reliably deleted by their UUID, which we need to store somewhere. Signed-off-by: Leon Schoch <[email protected]>
…s to switch and remove them on instance shutdown Signed-off-by: Leon Schoch <[email protected]>
…ntries." This reverts commit 08fe130. Signed-off-by: Leon Schoch <[email protected]>
…e is given Signed-off-by: Leon Schoch <[email protected]>
… Todos; Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
Signed-off-by: Leon Schoch <[email protected]>
DarkressX
force-pushed
the
feat/ovn-bandwidth-limit
branch
from
52844c0 to
648461c
Compare
Signed-off-by: Leon Schoch <[email protected]>
…s/egress limits Signed-off-by: Leon Schoch <[email protected]>
Member
|
Thanks, that looks very good! It's very late here but I should be able to do some tidying up of the branch and merge that tomorrow before Incus 6.19. |
Contributor
Author
|
No worries :) |
Member
|
Looking into this one now |
Member
|
Ah right, you're using an org account so I can't easily do in-place rebase/tweaks. I'll pull the commits into one of my branches, then do the tweaks there and close this PR once mine is up. |
Contributor
Author
|
Ah sorry, I wasn't aware of that limitation. I can rebase it too if thats easier :) |
Member
|
I opened #2711 which has effectively identical code except for the extra API extension commit, rebased content and slightly tweaked commit descriptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #2654
This PR implements the creation of ingress and egress bandwidth limits on an instance level.
These limits are converted to ovn compatible QoS rules.
I decided to make the
limits.ingressandlimits.egressconfig mutually exclusive withlimits.max, as I think it could be confusing for users, as they would be unsure which limit is actually being set if both configuration options are given.