Workaround Linstor URL parsing issue#2677
Merged
Conversation
This avoids the broken parser in golinstor which chokes on IPv6 addresses. Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
tych0
approved these changes
Nov 19, 2025
Signed-off-by: Stéphane Graber <[email protected]>
There is no mechanism to override govulncheck for the situation where it reports a security issue with no available fixes and where the code in question isn't in use in the project. Instead it fails and prevents any further change to be merged until an eventual release of a fix. So just make it informational and rely on dependency-review (Github Action) instead for the blocking checks as that one can have exceptions correctly added. Signed-off-by: Stéphane Graber <[email protected]>
jarrodu
reviewed
Nov 20, 2025
| controllerUrls := strings.Split(controllerConnection, ",") | ||
| c, err := linstorClient.NewClient(linstorClient.Controllers(controllerUrls), linstorClient.HTTPClient(httpClient), linstorClient.Log(linstorLogger{})) | ||
|
|
||
| parseConnection := func(connection string) (*url.URL, error) { |
There was a problem hiding this comment.
Should we add a comment with a bit of context? If the upstream issue is fixed then this block of code might not need to be here.
Member
Author
There was a problem hiding this comment.
I'm subscribed to the upstream issue, but their current parsing is very very weird and even if they relax the port restriction to make things work here, I'm not sure I'd want to use the rest of the logic. We're likely better off doing our own parsing here and just telling Linstor exactly what to connect to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream issue is LINBIT/golinstor#19