cmd/generate-config: address golangci-lint issues by RageZBla · Pull Request #2660 · lxc/incus

RageZBla · 2025-11-15T23:53:29Z

This PR relates to #2636 and address the lint issues in cmd/generate-config

cmd/generate-config/incus_doc.go

stgraber · 2025-11-16T00:47:47Z

A few small fixes needed (separation between code blocks).

Also, did you run make update-metadata to confirm that those changes don't actually lead to any change to the generated output?

RageZBla · 2025-11-16T06:45:43Z

doc/config_options.txt

@stgraber I am not sure if that's expected, the check on cast are not going to change behavior. If the cast would not happen without the check it would panic.

We'll need to figure out exactly what change is causing the change to the generated output. It may be that using temporary variables somehow impacts iteration order or something.

RageZBla · 2025-11-16T06:46:46Z

A few small fixes needed (separation between code blocks).

@stgraber thanks for reviewing. Do we have the wsl golangci-lint linter enable? I mean the linter was happy without the line break.

Also, did you run make update-metadata to confirm that those changes don't actually lead to any change to the generated output?

I did commit the output of the task/job after it seems mostly reordering. Maybe you are hinting that some behavior changed but it should not be the case.

stgraber · 2025-11-17T08:12:08Z

@stgraber thanks for reviewing. Do we have the wsl golangci-lint linter enable? I mean the linter was happy without the line break.

No but we have our own variation of it in later static analysis tests.

stgraber · 2025-11-17T08:13:31Z

I did commit the output of the task/job after it seems mostly reordering. Maybe you are hinting that some behavior changed but it should not be the case.

Yeah, each block must start by the config:option line or it's going to be completely invalid and wreck the documentation, so the change that's happening here is very very wrong :)

RageZBla · 2025-11-17T17:30:10Z

I did commit the output of the task/job after it seems mostly reordering. Maybe you are hinting that some behavior changed but it should not be the case.

Yeah, each block must start by the config:option line or it's going to be completely invalid and wreck the documentation, so the change that's happening here is very very wrong :)

I see, let me do some research and see what went wrong.

RageZBla · 2025-11-17T17:32:17Z

@stgraber thanks for reviewing. Do we have the wsl golangci-lint linter enable? I mean the linter was happy without the line break.

No but we have our own variation of it in later static analysis tests.

@stgraber any way to run that check locally?

stgraber · 2025-11-17T17:42:12Z

make static-analysis runs everything

RageZBla · 2025-11-23T01:34:11Z

@stgraber I think this version is not breaking the documentation anymore, if you can confirm. I am not sure why some of the tests are failing but it looks like some dependencies can't be download so it might have been temporary.

Signed-off-by: Olivier Lechevalier <[email protected]>

RageZBla requested a review from stgraber as a code owner November 15, 2025 23:53

RageZBla mentioned this pull request Nov 15, 2025

Get the entire code base to pass golangci-lint run #2636

Open

stgraber reviewed Nov 16, 2025

View reviewed changes