incusd: only apply qemu rtc adjustments if it is configured#2645
Merged
incusd: only apply qemu rtc adjustments if it is configured#2645
Conversation
Contributor
Author
|
Not 100% sure if the if check makes sense. Incus might just always write a value in this field anyways. Either way moving this piece of code closer to the command execution should fix the issue. |
This commit makes it so that we do not pass the -rtc option to qemu if it is configured. And also moves it down closer to the actual qemu call to reduce time shift. Signed-off-by: karo <[email protected]>
The127
force-pushed
the
kkostial/fix-rtc-adjustment
branch
from
1a96fb2 to
f78d208
Compare
stgraber
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it so that we do not pass the -rtc option to qemu if it is configured. And also moves it down closer to the actual qemu call to reduce time shift.
We have noticed up to 7 seconds of discrepancy in some cases (without passing an adjustment in the configuration).