cmd/generate-database/db: Fix create/update with composite keys#2616
Merged
cmd/generate-database/db: Fix create/update with composite keys#2616
Conversation
Signed-off-by: Max Asnaashari <[email protected]>
stgraber
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an edge-case where more parameters were being created than could be populated with struct field values.
Example:
table_ahas columnstable_b_id(joins totable_b) andtable_c_id(joins totable_c)table_bhas a composite keynameandtable_c_id(joins totable_c)When generating statements for
table_a, we shouldn't need 2 parameters fortable_c_id, we just need one and we can re-use the value we got for the other column.